Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to skip pod health checks with --wait=false #4744

Merged
merged 7 commits into from
Jul 18, 2019
Merged

Allow users to skip pod health checks with --wait=false #4744

merged 7 commits into from
Jul 18, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Jul 12, 2019 •
edited
Loading

This saves about 1 minute of run time, and will be useful for integrating with other applications which may do their own health checking. This flag behaves the same as the similarly named flag in kind, with one important difference: we leave the default as true for a more predictable start-up sequence, at the expense of startup latency. This was also the behavior in minikube up until v1.0.

This PR also sets --wait=false to all tests where it's possible to begin testing without all of the services online, such as CoreDNS or etcd. As a result, this PR decreases integration testing time by ~9 minutes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@tstromberg tstromberg changed the title Add --wait-until-healthy flag to skip pod health checks Add --wait flag to allow users to skip waiting for services to become healthy Jul 12, 2019
@tstromberg tstromberg changed the title Add --wait flag to allow users to skip waiting for services to become healthy Add --wait flag to allow users to skip pod verification Jul 12, 2019
@tstromberg tstromberg changed the title Add --wait flag to allow users to skip pod verification Allow users to skip pod health validating by using --wait=false Jul 12, 2019
@tstromberg tstromberg changed the title Allow users to skip pod health validating by using --wait=false Allow users to skip pod health checks with --wait=false Jul 12, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jul 12, 2019

/retest this please

@afbjorklund
Copy link
Collaborator

If you change your mind (or your cluster is acting weird), can you run the health checks afterwards ?

@tstromberg
Copy link
Contributor Author

If you change your mind (or your cluster is acting weird), can you run the health checks afterwards ?

Not yet, but you bring a good point. We should extend status to have the same model of pod healthiness as start. I'd prefer to introduce that as a second PR though, as it does pose some challenges to how the status command is currently implemented.

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

The one failure here appears to be #4418 - just looking for more test data:

--- FAIL: TestVersionUpgrade (143.72s)
    util.go:130: Error running command: start --vm-driver=none  --v=10 --logtostderr --...
          - error: failed to create listener: failed to listen on 0.0.0.0:8443: listen tcp 0.0.0.0:8443: bind: address already in use

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

PTAL - passes all tests, amazingly.

@tstromberg tstromberg merged commit b992c45 into kubernetes:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tstromberg @k8s-ci-robot @medyagh @afbjorklund @sharifelgamal