-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for minikube CLI commands #4647
Add documentation for minikube CLI commands #4647
Conversation
Hi @blueelvis. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blueelvis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
These are very likely to get out of date, due to the duplication of information... Could we use something automated, similar to |
@minikube-bot OK to test |
Thanks for this PR! I do agree with afbjorklund@ - these docs are great right now, but will get stale very fast. The command-line framework we are using, Cobra, allows automatic generation of markdown docs. https://github.com/spf13/cobra/blob/master/doc/md_docs.md By auto-generating docs, we can guarantee that users who are using |
@minikube-bot OK to test |
@afbjorklund @tstromberg - Agreed. Let me try using Cobra's auto generation and get back. |
I thought about this some more: we should not let perfect be the enemy of good, particularly when it comes to documentation. If Cobra auto-generation turns out to be difficult, I would be rather accept this doc as is, and replace it with automation as soon as possible. Let me know how your experiment goes. Thank you! |
@tstromberg @afbjorklund - This looks really promising. I generated the attached (start.txt) markdown file for the The Let me know if you are open to merge this PR now and I can work on another one meanwhile to integrate this with all of our commands and have something automated? |
@minikube-bot OK to test |
ping @tstromberg |
Happy to merge this one now while we work out how to automate it. Thank you for writing this up! |
Fixes #4271
This is the first pass on documenting the options, commands and flags available in the
minikube
CLI.I went ahead and added for all the commands and not only the
start
command as mentioned in the issue./assign tstromberg