Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added integration tests for registry #4639

Merged
merged 11 commits into from
Jul 17, 2019
Merged

Added integration tests for registry #4639

merged 11 commits into from
Jul 17, 2019

Conversation

castlemilk
Copy link
Contributor

@castlemilk castlemilk commented Jun 29, 2019 •
edited
Loading

Adding integration tests for the registry addon as mentioned in #4637. Validates the following functions:

  • registry is accessible from within the cluster (via an busybox pod)
  • registry is accessible from outside the cluster (via newly added registry-proxy)

This aims to prevent breaking changes in the future with regards to modifying the registry addon configuration and functionality.
This PR simply uses curl to validate connectivity is functional, it may be worthwhile actually pushing/pulling images from the registry from the different ingress mechanisms

@medyagh

castlemilk and others added 5 commits June 29, 2019 18:17
@castlemilk
added integration tests for registry addon
bb0417c
@castlemilk
added integration tests for registry addon
de424fe
@castlemilk
added integration tests for registry addon
00eb840
@josedonizetti @castlemilk
# This is a combination of 8 commits.
ad97983 
# This is the 1st commit message:

Fix doc comment version.gitCommitID doc


# This is the commit message kubernetes#2:

Add hyperkit doc


# This is the commit message kubernetes#3:

Add commit id to docker-machine-driver-kvm2 version


# This is the commit message kubernetes#4:

removed label selector for registry-proxy daemonset

# This is the commit message kubernetes#5:

Add support to custom qemu uri on kvm2 driver


# This is the commit message kubernetes#6:

Improve hyperkit vm stop


# This is the commit message kubernetes#7:

Make virtualbox DNS settings configurable 


# This is the commit message kubernetes#8:

added integration tests for registry addon
@castlemilk
Merge branch 'registry-integration-tests' of github.com:castlemilk/mi…
63c5434 
…nikube into registry-integration-tests
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @castlemilk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 29, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2019
@medyagh
Copy link
Member

medyagh commented Jun 29, 2019

Unit tests failed?

@castlemilk
Copy link
Contributor Author

@medyagh resolved linting issue.

@medyagh
Copy link
Member

medyagh commented Jun 30, 2019

@minikube-bot OK to test

medyagh
medyagh requested changes Jun 30, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution, please change the curl to use retryablehttp "github.com/hashicorp/go-retryablehttp" instead.

test/integration/addons_test.go Outdated Show resolved Hide resolved
@medyagh medyagh changed the title Registry integration tests Added integration tests for registry Jun 30, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2019
@RA489
Copy link

RA489 commented Jul 1, 2019

@minikube-bot OK to test

1 similar comment
@castlemilk
Copy link
Contributor Author

@minikube-bot OK to test

medyagh
medyagh requested changes Jul 1, 2019
View reviewed changes
test/integration/addons_test.go Outdated Show resolved Hide resolved
@castlemilk castlemilk force-pushed the registry-integration-tests branch 2 times, most recently from 87b63de to 94e92fd Compare July 6, 2019 09:01
@tstromberg
Copy link
Contributor

PR looks great. Will be happy to merge it once comment is resolved.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: castlemilk
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@castlemilk
Copy link
Contributor Author

@tstromberg Done! 🎉

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

Thank you!

@tstromberg tstromberg merged commit 1d567ea into kubernetes:master Jul 17, 2019
@castlemilk castlemilk mentioned this pull request Jul 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg left review comments

@medyagh medyagh medyagh requested changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@castlemilk @k8s-ci-robot @minikube-bot @medyagh @RA489 @tstromberg @josedonizetti