Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register registry-proxy.yaml.tmpl with registry addons #4529

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

kumarom
Copy link
Contributor

@kumarom kumarom commented Jun 19, 2019

Related to #4341

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kumarom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 19, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

/approve /lgtm

Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kumarom, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@medyagh
Copy link
Member

medyagh commented Jun 19, 2019

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jun 19, 2019

we need documentation for this great feature, we could have added as second option under this, (the documentation could be done in a separate PR)

https://github.com/kubernetes/minikube/blob/master/docs/reusing_the_docker_daemon.md

@medyagh
Copy link
Member

medyagh commented Jun 19, 2019

Failing test is related to #4495

looks good to me

@medyagh medyagh merged commit bf50225 into kubernetes:master Jun 19, 2019
@kumarom kumarom deleted the registry-proxy branch June 20, 2019 04:13
kumarom added a commit to kumarom/minikube that referenced this pull request Jun 20, 2019
This commit adds documentation on how to use minikube addon registry.
Related to kubernetes#4341 and kubernetes#4529
Resolves kubernetes#4531 and kubernetes#4242
kumarom added a commit to kumarom/minikube that referenced this pull request Jun 20, 2019
This commit adds documentation on how to use minikube addon registry.
Related to kubernetes#4341 and kubernetes#4529
This addresses kubernetes#4531 and kubernetes#4242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants