-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register registry-proxy.yaml.tmpl with registry addons #4529
Conversation
Hi @kumarom. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/approve /lgtm Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kumarom, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@minikube-bot OK to test |
we need documentation for this great feature, we could have added as second option under this, (the documentation could be done in a separate PR) |
Failing test is related to #4495 looks good to me |
This commit adds documentation on how to use minikube addon registry. Related to kubernetes#4341 and kubernetes#4529 Resolves kubernetes#4531 and kubernetes#4242
This commit adds documentation on how to use minikube addon registry. Related to kubernetes#4341 and kubernetes#4529 This addresses kubernetes#4531 and kubernetes#4242
Related to #4341