Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding retriable http get #4474

Merged
merged 3 commits into from
Jun 14, 2019

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jun 12, 2019

to address issues like this #4418

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2019
@RA489
Copy link

RA489 commented Jun 13, 2019

/retest

@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

1 similar comment
@medyagh
Copy link
Member Author

medyagh commented Jun 14, 2019

@minikube-bot OK to test

@medyagh
Copy link
Member Author

medyagh commented Jun 14, 2019

/retest this please

@sharifelgamal sharifelgamal merged commit 4485692 into kubernetes:master Jun 14, 2019
@medyagh medyagh deleted the 4418_fixTestVersionUpgrade branch June 14, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants