Add support for Kubernetes v1.15.0-beta.1 #4469
Conversation
|
Hi @fenglixa. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
DNS test fail which is not related to the modification: /retest |
|
@minikube-bot OK to test |
|
It can not take effect when I try to retest the integration. Could someone help on it? Thanks |
|
/retest |
|
Thanks @RA489. but seems it is also not take effect. |
|
@minikube-bot OK to test |
|
/retest this please |
|
/retest |
|
/approve /lgtm Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fenglixa, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tstromberg
changed the title
Fix for k8s v1.15-beta1: kubelet: unknown flag: --allow-privileged #4371
Why this fix
From change logs of kubernetes. The deprecated Kubelet flag --allow-privileged has been removed since v1.15.0-alpha.3.
UT after fix
Build & Test
From PR minikube support for k8s v1.15 #4412, the code should be merged after 1.2.0 release. But since I changed the code to take effect when k8s version <= 1.15.0-alpha.3, I think we can merge it as earlier as possible. How do you think?