Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: don't use ssh runner for the none driver #4439

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

afbjorklund
Copy link
Collaborator

Closes #4438

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@medyagh
Copy link
Member

medyagh commented Jun 6, 2019

I am curious does this also fix this issue ? #4132
Currently if you start minikube with none driver and then repeat the start command, it fails on waiting for SSH

@sharifelgamal sharifelgamal merged commit 80e200e into kubernetes:master Jun 6, 2019
@andrewjcouzens
Copy link

@medyagh I just tried compiling this and attempting to use vmdriver=none and I can confirm this patch doesn't fix it, at least not for me.

1031 15:49:51.248712 12005 main.go:110] libmachine: Waiting for SSH to be available...
I1031 15:49:51.248732 12005 main.go:110] libmachine: Getting to WaitForSSH function...
I1031 15:49:51.248750 12005 main.go:110] libmachine: Error getting ssh command 'exit 0' : driver does not support ssh commands

@medyagh
Copy link
Member

medyagh commented Oct 31, 2019

@andrewjcouzens did you compile against HEAD ? if yes, that would be a bug ! we could create an issue to track it, or re-open the other one

@andrewjcouzens
Copy link

andrewjcouzens commented Nov 1, 2019

@medyagh Yes I compiled against HEAD. Do you mean re-open 4132? If so, it was already open and so I left a comment showing my results (#4132 (comment)). If there is another ticket regarding this issue please let me know and I can also share there. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu: error for minikube cache add images
5 participants