Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube support for k8s v1.15 #4412

Closed
wants to merge 43 commits into from
Closed

minikube support for k8s v1.15 #4412

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
d40751f
Fix nonexistent profile
fenglixa May 31, 2019
bbc679b
modify to exit.Unavailable and align the code
fenglixa Jun 2, 2019
8e650c0
Dashboard: add --disable-settings-authorizer to avoid settings 403 fo…
fenglixa Jun 2, 2019
5129e6f
adding medyagh to approvers
medyagh Jun 2, 2019
8ba3e4d
minikube support for k8s v1.15
fenglixa Jun 3, 2019
79410c1
update case according to code changes
fenglixa Jun 3, 2019
6aa51c1
Merge pull request #4396 from fenglixa/fix-dashboard-nonexistent
sharifelgamal Jun 3, 2019
ed8d55c
Fixing TestProxy Setup
medyagh May 30, 2019
578a5e3
Merge remote-tracking branch 'upstream/master' into 4339
medyagh Jun 4, 2019
15cc4f8
Adding non-parallel dashboard test for proxy
medyagh Jun 4, 2019
6d57b28
changing string driver name to checked type
medyagh Jun 4, 2019
79ba9a1
typo
medyagh Jun 4, 2019
7c8a0e2
fix mistake logic
medyagh Jun 4, 2019
0151153
Merge pull request #4383 from medyagh/4339
sharifelgamal Jun 4, 2019
d556d58
Merge pull request #4405 from fenglixa/fix-4367
k8s-ci-robot Jun 5, 2019
2806396
Merge pull request #4419 from medyagh/none_struct
sharifelgamal Jun 5, 2019
bb78d3e
fix ShowDriverDeprecationNotification config setting
Pradip-Khakurel Jun 5, 2019
bb8ab6d
adding hyperv integration script
medyagh Jun 5, 2019
ed5e342
Merge pull request #4432 from medyagh/hyperv3591
sharifelgamal Jun 5, 2019
b9ecd55
fixing file path for windows
medyagh Jun 5, 2019
c58a3b6
Fixing filepath to be os agnostic
medyagh Jun 6, 2019
f4aaef7
Cache: don't use ssh runner for the none driver
afbjorklund Jun 6, 2019
53e8f9d
Merge pull request #4434 from medyagh/4433_filepath
sharifelgamal Jun 6, 2019
34bd9be
Add libvirt and qemu-kvm install docs for openSUSE/SLES
toabctl Jun 6, 2019
70cdf33
Merge pull request #4443 from toabctl/opensuse-install-docs
sharifelgamal Jun 6, 2019
80e200e
Merge pull request #4439 from afbjorklund/cache-none
sharifelgamal Jun 6, 2019
7119f57
Upgrade to kubernetes 1.14.3
sharifelgamal Jun 6, 2019
dfd9b6b
Merge pull request #4431 from Pradip-Khakurel/issue-#4161-WantShowDri…
sharifelgamal Jun 7, 2019
7d89ac1
Merge pull request #4444 from sharifelgamal/k8s-1.14.3
sharifelgamal Jun 7, 2019
9a7d0a0
Update Makefile for 1.1.1 release
sharifelgamal Jun 7, 2019
993c86c
Update CHANGELOG for 1.1.1 release
sharifelgamal Jun 7, 2019
ca886a6
Merge pull request #4446 from sharifelgamal/1.1.1
sharifelgamal Jun 7, 2019
ef60a69
Merge pull request #4448 from sharifelgamal/1.1.1-release-notes
sharifelgamal Jun 7, 2019
8e4c6c9
Update releases.json to include v1.1.1
minikube-bot Jun 7, 2019
7d0c27a
Merge pull request #4449 from minikube-bot/jenkins-releases.json-v1.1.1
sharifelgamal Jun 7, 2019
c0570f1
Mention v1.1.1 release
tstromberg Jun 10, 2019
ec1fe5a
Remove a couple of changes that aren't user facing
tstromberg Jun 10, 2019
9948ade
Clarify updating the minikube front page
tstromberg Jun 10, 2019
12a8274
3 releases rather than 4
tstromberg Jun 10, 2019
eb96756
Merge pull request #4408 from medyagh/approver
sharifelgamal Jun 10, 2019
88ed101
update to the minimum version of supporting --allow-privileged
fenglixa Jun 11, 2019
ff4e278
squash the commits
fenglixa Jun 3, 2019
dfbca14
Merge branch 'support_k8s_v1.15' of https://github.com/fenglixa/minik…
fenglixa Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/minikube/bootstrapper/kubeadm/kubeadm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Wants=crio.service

[Service]
ExecStart=
ExecStart=/usr/bin/kubelet --allow-privileged=true --authorization-mode=Webhook --bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf --cgroup-driver=cgroupfs --client-ca-file=/var/lib/minikube/certs/ca.crt --cluster-dns=10.96.0.10 --cluster-domain=cluster.local --container-runtime=remote --container-runtime-endpoint=/var/run/crio/crio.sock --fail-swap-on=false --hostname-override=minikube --image-service-endpoint=/var/run/crio/crio.sock --kubeconfig=/etc/kubernetes/kubelet.conf --pod-manifest-path=/etc/kubernetes/manifests --runtime-request-timeout=15m
ExecStart=/usr/bin/kubelet --authorization-mode=Webhook --bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf --cgroup-driver=cgroupfs --client-ca-file=/var/lib/minikube/certs/ca.crt --cluster-dns=10.96.0.10 --cluster-domain=cluster.local --container-runtime=remote --container-runtime-endpoint=/var/run/crio/crio.sock --fail-swap-on=false --hostname-override=minikube --image-service-endpoint=/var/run/crio/crio.sock --kubeconfig=/etc/kubernetes/kubelet.conf --pod-manifest-path=/etc/kubernetes/manifests --runtime-request-timeout=15m

[Install]
`,
Expand Down
9 changes: 8 additions & 1 deletion pkg/minikube/bootstrapper/kubeadm/versions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,14 @@ var versionSpecificOpts = []VersionedExtraOption{

// System pods args
NewUnversionedOption(Kubelet, "pod-manifest-path", "/etc/kubernetes/manifests"),
NewUnversionedOption(Kubelet, "allow-privileged", "true"),
{
Option: util.ExtraOption{
Component: Kubelet,
Key: "allow-privileged",
Value: "true",
},
LessThanOrEqual: semver.MustParse("1.14.2"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed in 1.14.3 ? Maybe this should be < 1.15 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afbjorklund I checked change logs of v1.15.0-beta.1. The deprecated Kubelet flag --allow-privileged has been removed since v1.15.0-alpha.3. So here should change to <= 1.15.0-alpha.3.
Sorry for my mistake, and thanks for your reminder.

},

// Network args
NewUnversionedOption(Kubelet, "cluster-dns", "10.96.0.10"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/minikube/constants/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ var DefaultISOSHAURL = DefaultISOURL + SHASuffix
var DefaultKubernetesVersion = "v1.14.2"

// NewestKubernetesVersion is the newest Kubernetes version to test against
var NewestKubernetesVersion = "v1.14.2"
var NewestKubernetesVersion = "v1.15.0-beta.1"

// OldestKubernetesVersion is the oldest Kubernetes version to test against
var OldestKubernetesVersion = "v1.10.13"
Expand Down