Add kvm2 --version

[josedonizetti]

FIx #4387

Considerations:

• I've added a version.go to the kvm driver instead of importing minikube/version
• As we are only supporting --version, I didn't use cobra/viper

Let me know what you think. I'll add it to hyperkit, once this one was approved.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

@minikube-bot OK test

[medyagh]

@josedonizetti thank for your contributions, would you please add documentation and integration tests for it ? and how one would use this --version ?

[josedonizetti]

@medyagh The usage will be docker-machine-driver-kvm2 --version. The idea is to simplify issues communication about the kvm2 driver, the user would have a simple way to know the driver is outdated, and probably the reason it's currently failing. I'll add the documentation and tests. Thanks

[blueelvis]

@medyagh @josedonizetti I think it should be --kvm-version instead of just --version. That way, people don't get confused if that is the minikube's version or the kvm driver version. What do you think?

[josedonizetti]

@blueelvis I think the command docker-machine-driver-kvm2 --version is very explanatory that is not the same as minikube --version. Yet, no strong feelings about it, let's see what others think. :)

[josedonizetti]

@medyagh Hey, have any pointers on adding integration tests for this?