Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestProxy #4383

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Fix TestProxy #4383

merged 3 commits into from
Jun 4, 2019

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented May 30, 2019 •
edited
Loading

To address this issue #4339.
and making sure minikube is deleted before/after test avoid #4132

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @medyagh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@medyagh medyagh requested a review from tstromberg May 30, 2019 20:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: medyagh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ra489

If they are not already assigned, you can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2019
@k8s-ci-robot k8s-ci-robot requested a review from RA489 May 30, 2019 20:06
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh medyagh changed the title Increase TestProxy Timeout WIP: Increase TestProxy Timeout May 30, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2019
@medyagh medyagh changed the title WIP: Increase TestProxy Timeout WIP: Fix TestProxy May 30, 2019
@medyagh medyagh self-assigned this May 30, 2019
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2019
@medyagh
Copy link
Member Author

medyagh commented May 30, 2019

@minikube-bot OK to test

@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2019
@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 31, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2019
@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 31, 2019
@medyagh
Copy link
Member Author

medyagh commented May 31, 2019

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2019
@medyagh
Copy link
Member Author

medyagh commented Jun 2, 2019 •
edited
Loading

Turns out the issue for this test is related to #4132
the root cause is, happens only in "None driver integration":
the test starts an already started minikube. and that fails the test on waiting for ssh

the root cause needs to be address in #4132 meanwhile we can make sure the TestProxy doesn't start an already started minikube for this test

@medyagh medyagh added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 2, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2019
@medyagh
Copy link
Member Author

medyagh commented Jun 2, 2019

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2019
@medyagh
Fixing TestProxy Setup
ed8d55c 
making sure minikube is deleted before setup to avoid kubernetes#4132
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2019
@medyagh medyagh changed the title WIP: Fix TestProxy Fix TestProxy Jun 4, 2019
@sharifelgamal sharifelgamal merged commit 0151153 into kubernetes:master Jun 4, 2019
@medyagh medyagh deleted the 4339 branch June 5, 2019 17:52
This was referenced Jun 5, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@tstromberg tstromberg Awaiting requested review from tstromberg

@RA489 RA489 Awaiting requested review from RA489

Assignees

@medyagh medyagh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@medyagh @k8s-ci-robot @minikube-bot @tstromberg @sharifelgamal