kvm2: Add support for --kvm-network to ensureNetwork

[josedonizetti]

kvm ensureNetwork is directly checking for the constant defaultNetworkName which is a problem when a user is passing a custom network through the option --kvm-network.

Kvm drivers pass the Network to be the same as the flag --kvm-network.
https://github.com/kubernetes/minikube/blob/master/pkg/minikube/drivers/kvm/driver.go#L67
https://github.com/kubernetes/minikube/blob/master/pkg/minikube/drivers/kvm2/driver.go#L67

Even the default Host creation sets up the Network:
https://github.com/kubernetes/minikube/blob/master/pkg/drivers/kvm/kvm.go#L107

The PR changes ensureNetwork to use the given network instead of hardcoded constant.

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

So that we don't break this in the future, do you mind adding --kvm-network to our integration tests?

I recommend adding it to the list of flags tested by the nocache_oldest subtest within start_stop_delete_test.go, as the integration test latency is already ridiculously high. Thank you!

[tstromberg]

Remove obsolete comment. The logging messages tell enough of a story.

[tstromberg]

@minikube-bot OK to test

[k8s-ci-robot]

Hi @josedonizetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sharifelgamal

If they are not already assigned, you can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[josedonizetti]

@tstromberg Let me know if I got the integration test correct (unfortunately they break locally even without my change). Also, do you want me to squash the commits into one?

[tstromberg]

@tstromberg Let me know if I got the integration test correct (unfortunately they break locally even without my change). Also, do you want me to squash the commits into one?

No need to squash. I'm curious though about the local breakage - what are you seeing?

[josedonizetti]

@tstromberg The integration tests are running now. Seems the tests I did with the --kvm-network left the minikube/kvm in a bad state, which wasn't allowing a start and breaking the tests, not even start it on the cmd directly was working, after removing the kvm domain by hand, it passed.

I'll investigate this a little bit more, and try to address in a separate PR.

[josedonizetti]

@tstromberg Builds for KVM, and VirtualBox never returned? It seems none build is breaking elsewhere as well.

[tstromberg]

@minikube-bot OK to test

FYI - the none failure is #4339