Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry addon ReplicationController template #4220

Merged
merged 1 commit into from
May 8, 2019

Commits on May 7, 2019

  1. Fix registry addon ReplicationController template

    Running the `minikube addons enable registry` yields `registry was successfully enabled` but no `registry` Pod ends up being run.
    
    I've narrowed it down to this `env` entry not being quoted.
    
    Logs from `kube-addon-manager-minikube` Pod show this error:
    
    ```
    Error from server (BadRequest): error when creating "/etc/kubernetes/addons/registry-rc.yaml": ReplicationController in version "v1" cannot be handled as a ReplicationController: v1.ReplicationController.Spec: v1.ReplicationControllerSpec.Template: v1.PodTemplateSpec.Spec: v1.PodSpec.Containers: []v1.Container: v1.Container.Env: []v1.EnvVar: v1.EnvVar.Value: ReadString: expects " or n, but found t, error found in kubernetes#10 byte of ...|,"value":true}],"ima|..., bigger context ...|"name":"REGISTRY_STORAGE_DELETE_ENABLED","value":true}],"image":"registry.hub.docker.com/library/reg|...
    ```
    zregvart authored May 7, 2019
    3 Configuration menu
    Copy the full SHA
    40da502 View commit details
    Browse the repository at this point in the history