Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make handling of stale mount pid files more robust #4191

Merged
merged 1 commit into from
May 3, 2019
Merged

Make handling of stale mount pid files more robust #4191

merged 1 commit into from
May 3, 2019

Conversation

tstromberg
Copy link
Contributor

This makes several updates around KillMountProcess:

  • Non-running pids no longer emit an error
  • Remove the pid file so that it is not forever stale
  • Failures emit a warning rather than crashing "stop"

This closes #4168

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2019
@tstromberg tstromberg changed the title Make handling of stale mount pidfile more robust Make handling of stale mount pid files more robust May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2019
@tstromberg tstromberg requested a review from medyagh May 2, 2019 17:24
@tstromberg tstromberg merged commit 163e74f into kubernetes:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@medyagh medyagh Awaiting requested review from medyagh

@balopat balopat Awaiting requested review from balopat

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to kill mount process: os: process already finished
3 participants
@tstromberg @k8s-ci-robot @sharifelgamal