-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unset the current-context after minikube stop #4177
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
df0a0ad
Unset the current-context on minikube stop
c8af727
Added tests to check current-context on start and stop of minikube
fb0127f
Fixed gofmt errors
a4018bf
Fixed the build error and formatting
a533b56
Fixed the test case
fd7277b
Changed the error message style in test case.
dd8d3cf
minor code change: Added strings.TrimRight()
e23a784
Added a param in the test case to find the current-context after stop
64f990c
Updated the test case
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,6 +115,7 @@ func PopulateKubeConfig(cfg *KubeConfigSetup, kubecfg *api.Config) error { | |
// Only set current context to minikube if the user has not used the keepContext flag | ||
if !cfg.KeepContext { | ||
kubecfg.CurrentContext = cfg.ClusterName | ||
//kubecfg.CurrentContext = "" | ||
} | ||
|
||
return nil | ||
|
@@ -312,3 +313,16 @@ func GetPortFromKubeConfig(filename, machineName string) (int, error) { | |
port, err := strconv.Atoi(kport) | ||
return port, err | ||
} | ||
|
||
//UnsetCurrentContext unsets the current-context from minikube to "" on minikube stop | ||
func UnsetCurrentContext(filename, machineName string) error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please run There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. formatted this one. |
||
confg, err := ReadConfigOrNew(filename) | ||
if err != nil { | ||
return errors.Wrap(err, "Error getting kubeconfig status") | ||
} | ||
confg.CurrentContext = "" | ||
if err := WriteConfig(confg,filename); err != nil { | ||
return errors.Wrap(err, "writing kubeconfig") | ||
} | ||
return nil | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done