Don't attempt to pull docker images on relaunch #4129
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @marcosdiez. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
|
@minikube-bot OK to test |
1 similar comment
|
@minikube-bot OK to test |
|
@marcosdiez please squash the commits to one |
cmd/minikube/cmd/start.go
Outdated
| @@ -574,6 +570,11 @@ func bootstrapCluster(bs bootstrapper.Bootstrapper, r cruntime.Manager, runner b | |||
| exit.WithLogEntries("Error restarting cluster", err, logs.FindProblems(r, bs, runner)) | |||
| } | |||
| return | |||
| } else { | |||
| console.OutStyle("pulling", "Pulling images required by Kubernetes %s ...", kc.KubernetesVersion) | |||
There was a problem hiding this comment.
I like this change - but there is a bit more subtlety here that is missing. This will also need to handle the case where the pre-existing cluster is a different version of Kubernetes.
There was a problem hiding this comment.
Here in Brazil it really saves me 30 seconds. So I will later send you will a PR to check if the server is being upgraded or not.
I read that you aim to make minikube launch in less than a minute.
With this patch (and all the others you have merged), here it loads in 53 seconds. How long does it take to load for you ?
tstromberg
added
do-not-merge/work-in-progress
|
Any idea on how much time this saves? I want to make sure the added complexity is worth it. |
marcosdiez
force-pushed
the
dont_pull_images_on_recreate
branch
from
04b4481
to
f1e83b9
Compare
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcosdiez If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
marcosdiez
force-pushed
the
dont_pull_images_on_recreate
branch
from
f1e83b9
to
3eb340b
Compare
|
@tstromberg Implementing the check was easier than I thought. And I only had to add 4 lines, one of them being blank. I also rebased, as requested by @RA489 . |
|
@minikube-bot OK to test |
Hi again!
If we are relaunching a cluster, we already have pulled the images (and if they ever got deleted, it's not the end of the world). That saves startup time!
The fact is, since I am physically far from the k8s.gcr.io servers, a simple
time sudo kubeadm config images pull --config "/var/lib/kubeadm.yaml"takes around 30 seconds if the images are already there.From an AWS server in the US the same command takes only 5 seconds, but, well, it's still a performance improvement without any downside :)
Please don't think that I have the worse connection on earth and hence I am an edge case. Quite the opposite. I am just physically far for
k8s.gcr.ioand therefore the latency is high`.