Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to disable style prefix #4118

Closed
wants to merge 1 commit into from

Conversation

afbjorklund
Copy link
Collaborator

Some people find the "style" prefix distracting and confusing,
whether it is shown in color emoji or in 7-bit compatible text.

So add a way to opt-out from the console prefix completely, this
will just show the message text starting from the first column.

From discussion in #3724

Some people find the "style" prefix distracting and confusing,
whether it is shown in color emoji or in 7-bit compatible text.

So add a way to opt-out from the console prefix completely, this
will just show the message text starting from the first column.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2019
@tstromberg
Copy link
Contributor

Rather than adding another knob to support, how about improving MINIKUBE_IN_STYLE?

While I have not yet seen complaints about the ASCII mode, it could be a bit more consistent. I think it's useful to support indentation, but perhaps we should just have a single standard prefix character for info "-" and another for error.

Thoughts?

@afbjorklund
Copy link
Collaborator Author

It just seemed like a better option than filtering the output afterwards, as was their current approach...

But maybe the style output can be tweaked enough to be acceptable ? Or convert it from a boolean ?

@afbjorklund
Copy link
Collaborator Author

A fourth approach was printing the style out in full, like they do in the subtitles:

😄  minikube v1.0.0 on linux (amd64)
o   minikube v1.0.0 on linux (amd64)
minikube v1.0.0 on linux (amd64)
[happy] minikube v1.0.0 on linux (amd64)

But maybe that would work better with categories, than with the current styles.

@RA489
Copy link

RA489 commented Apr 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg
Copy link
Contributor

tstromberg commented Apr 25, 2019

I'd rather not support 3 output modes if I could avoid it. Let's just tweak the default output style to be more acceptable.

Here's a straw-man proposal:

- top level item
  * second level item
! error/warning item

@tstromberg tstromberg removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 25, 2019
@afbjorklund
Copy link
Collaborator Author

I'm not going to pursue this further, so probably time to open a new issue for the original requester then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants