-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variable to disable style prefix #4118
Conversation
Some people find the "style" prefix distracting and confusing, whether it is shown in color emoji or in 7-bit compatible text. So add a way to opt-out from the console prefix completely, this will just show the message text starting from the first column.
Rather than adding another knob to support, how about improving MINIKUBE_IN_STYLE? While I have not yet seen complaints about the ASCII mode, it could be a bit more consistent. I think it's useful to support indentation, but perhaps we should just have a single standard prefix character for info "-" and another for error. Thoughts? |
It just seemed like a better option than filtering the output afterwards, as was their current approach... But maybe the style output can be tweaked enough to be acceptable ? Or convert it from a boolean ? |
A fourth approach was printing the style out in full, like they do in the subtitles:
But maybe that would work better with categories, than with the current styles. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, RA489 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd rather not support 3 output modes if I could avoid it. Let's just tweak the default output style to be more acceptable. Here's a straw-man proposal:
|
I'm not going to pursue this further, so probably time to open a new issue for the original requester then. |
Some people find the "style" prefix distracting and confusing,
whether it is shown in color emoji or in 7-bit compatible text.
So add a way to opt-out from the console prefix completely, this
will just show the message text starting from the first column.
From discussion in #3724