-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Run kubeadm init phase addon all
to ensure kube-proxy is up in v1.13+
#4014
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liubog2008 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
0224a81
to
30fd909
Compare
I signed it |
/check-cla |
1 similar comment
/check-cla |
Looks like a typo in the PR. At least my kubeadm complains on it. |
30fd909
to
9495633
Compare
thanks @neerdoc |
Thanks for the PR! Do you mind elaborating a bit on the "why" of this change in the PR description? I'm not sure what this does compared to the existing commands, and I'm additionally unsure what the connection between this PR and #3936 is. Thank you! |
@tstromberg That's my first comment. |
@@ -264,11 +264,11 @@ func addAddons(files *[]assets.CopyableFile, data interface{}) error { | |||
} | |||
|
|||
// waitForPods waits until the important Kubernetes pods are in running state | |||
func waitForPods(k8s config.KubernetesConfig, quiet bool) error { | |||
func waitForPods(k8s config.KubernetesConfig, quiet bool, componentsOnly bool) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having two bool arguments to a function is a bad code smell. Do you mind splitting this out into two functions? Perhaps something like:
waitForComponentPods and waitFork8sPods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
kubeadm init phase addon all
to ensure kube-proxy is up in v1.13+
kubeadm init phase addon all
to ensure kube-proxy is up in v1.13+kubeadm init phase addon all
to ensure kube-proxy is up in v1.13+
Any luck splitting waitForPods into two functions? |
Since there haven't been any updates to this, I've proposed a simpler solution in #4276 Thank you @liubog2008 for pointing us in the right direction for solving this nefarious problem. |
fix #3936 #3843
I find that kube-proxy is not created after
minikube start
(restart) so thatwaitForPods
always waits until timeout.kubeadm init phase addon all
can generate kube-proxy beforewaitForPods
.How to reproduce: