Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port name to service struct used in minikube service #4011

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

arnaudjardine
Copy link
Contributor

Fixes: #3351

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arnaudjardine
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: afbjorklund

If they are not already assigned, you can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! If you could please add a test for this in service_test.go, I would be very happy to see this get merged. Otherwise, we're bound to accidentally break this in a future release. :(

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2019
@arnaudjardine
Copy link
Contributor Author

Hi @tstromberg, I've added a test for that ;)

@tstromberg
Copy link
Contributor

Thank you!

@minikube-bot OK to test

@tstromberg tstromberg merged commit 0f93bdd into kubernetes:master Apr 9, 2019
@arnaudjardine arnaudjardine deleted the addPortNameAttribute branch April 11, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants