-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select an accessible image repository for some users #3937
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: laozc If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Now it's possible to fallback to a mirror site for those users who cannot access the main k8s.gcr.io repository. You may also set the --image-mirror-country to forcibly use a known local mirror in the specific location. Signed-off-by: Zhongcheng Lao <[email protected]>
@minikube-bot OK to test |
Looks good so far, though I'll need to give this a more careful review. Thank you! |
Since I like this change overall and want to see it merged, what do you think about supporting a flag, such as
|
Merging! I'm hoping to make "auto" the default once #4104 can be addressed. Thank you so much for your hard work here. |
Now it's possible to fallback to a mirror site for those users
who cannot access the main k8s.gcr.io repository. You may also
set the --image-mirror-country to forcibly use a known local
mirror in the specific location.