Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'config' flag to kubeadm. #3914

Closed
wants to merge 1 commit into from

Conversation

GeekMeUpScotty
Copy link

minikube start complains that --config is unsopprted. Proper flag name is --kubeconfig

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GeekMeUpScotty
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: afbjorklund

If they are not already assigned, you can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from balopat and dlorenc March 20, 2019 12:26
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@GeekMeUpScotty
Copy link
Author

GeekMeUpScotty commented Mar 20, 2019 via email

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 20, 2019
@GeekMeUpScotty
Copy link
Author

Actually... I am doubtful the flag is the real issue. From what I can read it looks like 'config' is the proper flag, provided kubeadm is recent enough!? So maybe the problem is that the image pulled is incorrect?

@tstromberg
Copy link
Contributor

tstromberg commented Mar 20, 2019

Thank you for this PR!

I was trying to solve the same issue with Kubernetes v1.10 with #3832 (just skipping "pull" for older Kubernetes releases), but I feel like a combination of our two approaches are better. I didn't realize until now that it was just a renamed flag.

If you don't mind, I'd like to take your idea and incorporate it into #3832 so that it works across all Kubernetes releases.

@tstromberg
Copy link
Contributor

So, it turns out that there is no "pull" command on older Kubernetes releases. I've merged #3832 which now simply warns v1.10 users that pull isn't possible, so this PR should be closeable now as well.

@tstromberg
Copy link
Contributor

Closing this PR because I don't think it is doing the right thing after all. Feel free to re-open if you disagree. Thank you for bringing this up!

@tstromberg tstromberg closed this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants