-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'config' flag to kubeadm. #3914
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GeekMeUpScotty If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
CLA registration done
Den ons. 20. mar. 2019 kl. 13.26 skrev Kubernetes Prow Robot <
[email protected]>:
… Thanks for your pull request. Before we can look at your pull request,
you'll need to sign a Contributor License Agreement (CLA).
📝 *Please follow instructions at
https://git.k8s.io/community/CLA.md#the-contributor-license-agreement
<https://git.k8s.io/community/CLA.md#the-contributor-license-agreement> to
sign the CLA.*
It may take a couple minutes for the CLA signature to be fully registered;
after that, please reply here with a new comment and we'll verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data and verify that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If you signed the CLA as a corporation, please sign in with your
organization's credentials at
https://identity.linuxfoundation.org/projects/cncf to be authorized.
- If you have done the above and are still having issues with the CLA
being reported as unsigned, please email the CNCF helpdesk:
***@***.***
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3914 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGjti8Y40fi_xDBF4IY2_UnHy10o1gdLks5vYijpgaJpZM4b_LWO>
.
|
Actually... I am doubtful the flag is the real issue. From what I can read it looks like 'config' is the proper flag, provided kubeadm is recent enough!? So maybe the problem is that the image pulled is incorrect? |
Thank you for this PR! I was trying to solve the same issue with Kubernetes v1.10 with #3832 (just skipping "pull" for older Kubernetes releases), but I feel like a combination of our two approaches are better. I didn't realize until now that it was just a renamed flag. If you don't mind, I'd like to take your idea and incorporate it into #3832 so that it works across all Kubernetes releases. |
So, it turns out that there is no "pull" command on older Kubernetes releases. I've merged #3832 which now simply warns v1.10 users that pull isn't possible, so this PR should be closeable now as well. |
Closing this PR because I don't think it is doing the right thing after all. Feel free to re-open if you disagree. Thank you for bringing this up! |
minikube start complains that --config is unsopprted. Proper flag name is --kubeconfig