Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Reference, allow caching images with both Tag and Digest #3899

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Use Reference, allow caching images with both Tag and Digest #3899

merged 2 commits into from
Apr 12, 2019

Conversation

afbjorklund
Copy link
Collaborator

Closes #3822

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@tstromberg
Copy link
Contributor

Any chance of adding an integration test to affirm that we don't break this in the future?

@tstromberg
Copy link
Contributor

FWIW, It has just come to my attention that minikube cache isn't covered by our integration tests.

😱

@afbjorklund
Copy link
Collaborator Author

Sounds like a good idea, for now I just tested it manually and locally.

@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2019
@afbjorklund afbjorklund removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2019
@afbjorklund afbjorklund mentioned this pull request Mar 28, 2019
Closed
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

Thanks for the PR! Please merge when ready.

@afbjorklund afbjorklund merged commit 2f1929f into kubernetes:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"cache add" with sha256 sum: "Failed to cache... repository can only contain the runes"
3 participants
@afbjorklund @k8s-ci-robot @tstromberg