Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Plumb HTTP proxy configuration from host into VM environment #3835

Closed
wants to merge 3 commits into from

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 9, 2019

Detect system proxy configuration from environment, and plumb them into the docker env and /etc/environment within the VM by default.

Proxies are tricky, so this will no doubt will require future improvements for various edge cases.

This addresses countless bugs that I'm sick of commenting on, but most of all it closes #3242

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2019
@tstromberg tstromberg changed the title Plumb system HTTP proxy configuration into VM environment Plumb HTTP proxy configuration from host into VM environment Mar 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2019
@afbjorklund
Copy link
Collaborator

195 files changed, 52464 insertions(+), 13462 deletions(-)

I'm thinking something went wrong here, with that vendor dep ?

@tstromberg tstromberg changed the title Plumb HTTP proxy configuration from host into VM environment WIP: Plumb HTTP proxy configuration from host into VM environment Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2019
@tstromberg
Copy link
Contributor Author

Things to address:

  • minikube should respect the discovered proxy
  • minikube should not plumb 127.0.0.1 as a proxy value
  • fix sys deps
  • more testing

@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2019
@tstromberg tstromberg self-assigned this Apr 30, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2019
@tstromberg
Copy link
Contributor Author

Closing until I have bandwidth to look into this again.

@tstromberg tstromberg closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagate HTTP proxy config into VM
3 participants