Fix minikube addons open heapster
#3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the default installation I get the same error: ``` $ minikube addons open heapster 💣 This addon does not have an endpoint defined for the 'addons open' command. You can add one by annotating a service with the label kubernetes.io/minikube-addons-endpoint:heapster ``` This PR is simply implementing the suggested fix by adding the aforementioned label to the heapster service.
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cristim If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tstromberg
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default installation of minikube 0.35.0 I get the following error when trying to open heapster:
This PR is simply implementing the suggested fix by adding the aforementioned label to the heapster service.