Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect style name mount #3789

Merged
merged 1 commit into from
Mar 5, 2019
Merged

fix incorrect style name mount #3789

merged 1 commit into from
Mar 5, 2019

Conversation

tomxor
Copy link
Contributor

@tomxor tomxor commented Mar 4, 2019 •
edited
Loading

when running minikube start with the --mount flag an error occurs due to incorrect style name.
log:

(☸ |minikube) ➜  minikube git:(master) ✗ ./out/minikube-linux-amd64 start --vm-driver kvm2 --mount
😄  minikube v0.34.1 on linux (amd64)
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.
🔄  Restarting existing kvm2 VM for "minikube" ...
⌛  Waiting for SSH access ...
📶  "minikube" IP address is XXX ...
🐳  Configuring Docker as the container runtime ...
✨  Preparing Kubernetes environment ...
🚜  Pulling images required by Kubernetes v1.13.3 ...
🔄  Relaunching Kubernetes v1.13.3 using kubeadm ...
⌛  Waiting for pods: apiserver proxy etcd scheduler controller addon-manager dns
📯  Updating kube-proxy configuration ...
🤔  Verifying component health ......
E0304 23:52:22.034088   28575 console.go:75] applyStyle(mount): unknown style: "mount"
Creating mount /home/XXX:/minikube-host ...
💗  kubectl is now configured to use "minikube"
🏄  Done! Thank you for using minikube!

might be best to add constants for those, wasn't sure if that was desired.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

tstromberg
tstromberg approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing a fix!

@tstromberg
Copy link
Contributor

/approve /lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomxor, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@tstromberg tstromberg merged commit abbc8b3 into kubernetes:master Mar 5, 2019
@tomxor tomxor deleted the mount-style-fix branch March 5, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomxor @minikube-bot @tstromberg @k8s-ci-robot