Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching: Fix containerd, improve console messages, add integration tests #3767

Merged
merged 6 commits into from
Mar 14, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 27, 2019

  • Change output messages to use "download" instead of "caching", for accuracy and familiarity.
  • 'ctr cri load' doesn't work, use 'ctr image import' instead.
  • LoadImage errors are no longer fatal, though it still outputs an error message to console.
  • TestStartStop now tests caching!
  • Allow integration tests to pass arguments directly to Start()

Closes #3651

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@afbjorklund
Copy link
Collaborator

Why did you need to use sudo for docker ? The default user should be part of the root-equivalent group:

$ ls -l /var/run/docker.sock 
srw-rw---- 1 root docker 0 Feb 28 16:48 /var/run/docker.sock
$ id
uid=1001(docker) gid=1001(docker) groups=1001(docker),10(wheel),1000(rkt),1018(rkt-admin),1019(vboxsf)

$ docker save busybox | gzip > busybox.tar.gz
$ docker load < busybox.tar.gz 
Loaded image: busybox:latest

https://docs.docker.com/install/linux/linux-postinstall/#manage-docker-as-a-non-root-user

@tstromberg
Copy link
Contributor Author

Why did you need to use sudo for docker ? The default user should be part of the root-equivalent group:

$ ls -l /var/run/docker.sock 
srw-rw---- 1 root docker 0 Feb 28 16:48 /var/run/docker.sock
$ id
uid=1001(docker) gid=1001(docker) groups=1001(docker),10(wheel),1000(rkt),1018(rkt-admin),1019(vboxsf)

$ docker save busybox | gzip > busybox.tar.gz
$ docker load < busybox.tar.gz 
Loaded image: busybox:latest

https://docs.docker.com/install/linux/linux-postinstall/#manage-docker-as-a-non-root-user

You appear to be completely correct. I put that change in a couple of weeks ago and completely forgot why I added sudo. The answer appears to be, for no reason at all. Thanks for questioning it!

@tstromberg tstromberg changed the title Fix docker/containerd caching, improve msgs, add tests Cache fixit: Fix containerd, improve console messages, add integration tests Feb 28, 2019
@tstromberg tstromberg changed the title Cache fixit: Fix containerd, improve console messages, add integration tests caching: Fix containerd, improve console messages, add integration tests Feb 28, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

2 similar comments
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg tstromberg added this to the v1.0.0 milestone Mar 11, 2019
@tstromberg
Copy link
Contributor Author

None failure: #3873

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants