-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caching: Fix containerd, improve console messages, add integration tests #3767
caching: Fix containerd, improve console messages, add integration tests #3767
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@minikube-bot OK to test |
Why did you need to use $ ls -l /var/run/docker.sock
srw-rw---- 1 root docker 0 Feb 28 16:48 /var/run/docker.sock
$ id
uid=1001(docker) gid=1001(docker) groups=1001(docker),10(wheel),1000(rkt),1018(rkt-admin),1019(vboxsf)
$ docker save busybox | gzip > busybox.tar.gz
$ docker load < busybox.tar.gz
Loaded image: busybox:latest https://docs.docker.com/install/linux/linux-postinstall/#manage-docker-as-a-non-root-user |
You appear to be completely correct. I put that change in a couple of weeks ago and completely forgot why I added sudo. The answer appears to be, for no reason at all. Thanks for questioning it! |
@minikube-bot OK to test |
@minikube-bot OK to test |
None failure: #3873 |
@minikube-bot OK to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #3651