Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CONFIG_NF_CONNTRACK_ZONES #3755

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Enable CONFIG_NF_CONNTRACK_ZONES #3755

merged 1 commit into from
Apr 9, 2019

Conversation

jojimt
Copy link
Contributor

@jojimt jojimt commented Feb 26, 2019 •
edited
Loading

This commit enables CONNTRACK_ZONES in the VM's kernel (#3731)
Additionally, the Makefile is updated to reflect the correct kernel version per #2986

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 26, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2019
@jojimt
Copy link
Contributor Author

jojimt commented Feb 26, 2019

fyi, I am working on the CLA.

@tstromberg
Copy link
Contributor

/approve

(assuming CLA is submitted)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jojimt, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@jojimt
Copy link
Contributor Author

jojimt commented Feb 28, 2019

I have an ETA of mid next week for the CLA.

@tstromberg
Copy link
Contributor

Any chance to get the CLA signed?

@jojimt
Copy link
Contributor Author

jojimt commented Mar 21, 2019

Unfortunately, this is taking longer than anticipated. Lawyers are citing slow response from CNCF as the reason. I will keep pushing and provide an update in a week. Thanks for bearing with this.

@jojimt
Copy link
Contributor Author

jojimt commented Mar 27, 2019

I was informed that the CLA is officially in place for me. Do I need to push something to retrigger the check?

@jojimt jojimt force-pushed the ct_zones branch 2 times, most recently from c1834c6 to edff1ee Compare March 27, 2019 20:34
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 27, 2019
@jojimt
Copy link
Contributor Author

jojimt commented Mar 28, 2019

@tstromberg The CLA part is now taken care of. I'm assuming nothing else is pending from my side.

tstromberg
tstromberg suggested changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the kernel downgrade?

@jojimt
Copy link
Contributor Author

jojimt commented Mar 28, 2019 •
edited
Loading

There is no kernel downgrade in this PR. The kernel change was by #2986. I just updated the Makefile to reflect the correct kernel version. Please see the comments at the end of #3731 for more details.

@jojimt
Copy link
Contributor Author

jojimt commented Apr 1, 2019

@tstromberg Is the explanation satisfactory? Do you still need me to revert the change in the Makefile?

@jojimt
Copy link
Contributor Author

jojimt commented Apr 5, 2019

@tstromberg any update?

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2019
@tstromberg
Copy link
Contributor

Looks great! Thanks for sticking through this process. It will be part of the next release.

@tstromberg tstromberg merged commit 1ed3900 into kubernetes:master Apr 9, 2019
@jojimt jojimt deleted the ct_zones branch April 9, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg requested changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jojimt @k8s-ci-robot @minikube-bot @tstromberg