-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of kubectl command #3646
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The implementation here seems sound, but after reviewing our uses of kubectl, I'm left wondering if this command is worth the technical debt it incurs. I feel that if users want to use kubectl, they may as well install it properly so that they may use it for a non-minikube cluster. Thoughts? |
As long as But after putting the poor user through: curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64
chmod +x minikube
sudo cp minikube /usr/local/bin && rm minikube The last thing to do is making them do:
Where it "forgets" to use the checksums, and is prone to using the wrong version of To be honest I am not sure why we require the user to have I've also seen at least a dozen different ways to do the above, with chown etc. |
93b8c40
to
9d85895
Compare
This command can use the new |
@minikube-bot OK to test |
This seems ready to merge once we have positive test results. |
Please rebase and merge once ready. Thanks! |
Will wait for 1.1 |
@minikube-bot OK to test |
Some duplication, always using default k8sFor #3645