Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libmachine to version 0.16.1 #3619

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

afbjorklund
Copy link
Collaborator

This is mostly manual, since dep is in a sad state at the moment:

# Gopkg.lock is out of sync

The major features from docker-machine upstream are these two:

  • The default storage driver has been updated to overlay2 for several systems
  • Improved error reporting for the ssh subcommand when using the --native-ssh flag

docker/machine@1903531...a773edc

The minikube boot2docker.iso was already using overlay2 for docker (3b97276).

The minikube minikube.iso always uses the default docker driver (i.e. overlay2).

Fixes #3525

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2019
@gbraad
Copy link
Contributor

gbraad commented Feb 3, 2019 via email

@afbjorklund
Copy link
Collaborator Author

@gbraad : I might have access, not sure if we should keep it though (i.e. the "machine" repo) ?
Have mostly used it for hosting https://github.com/machine-drivers/docker-machine-driver-qemu

For now I left the downstream patches (machine-drivers/machine@6f34be4) out of the update.
If you think that it is important, we could go for the latest master (docker/machine@61ef47d) ?

@tstromberg tstromberg merged commit eb67118 into kubernetes:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants