Use mac as identifier for dhcp

[leifcr]

This solves #951

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leifcr
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

If they are not already assigned, you can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[leifcr]

cla signed.

[tstromberg]

Looks great. Since we don't yet have an integration test for running multiple simultaneous profiles (#3576), do you mind testing that this PR doesn't break this workflow:

minikube start -p test1
minikube start -p test2
minikube ssh -p test1 hostname # assert that it says test1
minikube ssh -p test2 hostname # assert that it says test2
minikube delete -p test1
minikube delete -p test2

I assume it doesn't, but I just want to make sure of it before merging. Thank you!

[tstromberg]

@minikube-bot OK to test

[leifcr]

Console output:

$ minikube start -p test1 --iso-url file:///home/l/code/kube/minikube/minikube.iso
Starting local Kubernetes v1.13.2 cluster...
.... snipped
Everything looks great. Please enjoy minikube!

$ minikube start -p test2 --iso-url file:///home/l/code/kube/minikube/minikube.iso
Starting local Kubernetes v1.13.2 cluster...
.... snipped
Everything looks great. Please enjoy minikube!

$ minikube ssh -p test1 hostname
test1

$ minikube ssh -p test2 hostname
test2

$ minikube ip -p test1
192.168.99.100

$ minikube ip -p test2
192.168.99.101

$ minikube stop -p test1
Stopping local Kubernetes cluster...
Machine stopped.

$ minikube stop -p test2
Stopping local Kubernetes cluster...
Machine stopped.

$ minikube start -p test1
Starting local Kubernetes v1.13.2 cluster...
....

$ minikube start -p test2
Starting local Kubernetes v1.13.2 cluster...
.... 

$ minikube ip -p test1
192.168.99.100

$ minikube ip -p test2
192.168.99.101

$ minikube delete -p test1
Deleting local Kubernetes cluster...
Machine deleted.

$ minikube delete -p test2
Deleting local Kubernetes cluster...
Machine deleted.

[leifcr]

The is is uploaded here if needed for further testing: https://github.com/leifcr/minikube/releases/download/v0.33.1-iso-only/minikube-0.33.1-mac_fix.iso

[tstromberg]

Excellent. Thank you for the patch, and thank you for making minikube better!

[leifcr]

Thanks for merging!