Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save old cluster config in memory before overwriting #3450

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Save old cluster config in memory before overwriting #3450

merged 2 commits into from
Dec 13, 2018

Commits on Dec 13, 2018

  1. Save old cluster config in memory before overwriting 

    In PR kubernetes#3426, I changed "minikube start" to overwrite the cluster config earlier so that the container runtime could be extracted from it by the buildroot provisioner. This introduced a bug later on, where minikube expected to read the kubernetes version from theold config (which no longer existed, because the config was overwritten).

To fix this, I changed the code to store the old version of the config in memory before overwriting it.

This should fix kubernetes#3447
    Priya Wadhwa committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    9cd4a88 View commit details
    Browse the repository at this point in the history

  2. fix unit tests

    Priya Wadhwa committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    b117da3 View commit details
    Browse the repository at this point in the history