Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass network-plugin value to kubelet #3442

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Pass network-plugin value to kubelet #3442

merged 1 commit into from
Jan 11, 2019

Conversation

brb
Copy link
Contributor

@brb brb commented Dec 11, 2018

Previously, when minikube start has been invoked with --network-plugin=<..>, the value was not passed to kubelet. Therefore, the additional param --extra-config=kubelet.network-plugin=<..> was required.

This PR ensures that the value is being passed to kubelet, so the extra-config value is no longer needed.

Fixes #2828.

@brb
Pass network-plugin value to kubelet
e08423c 
Previously, when "minikube start" has been invoked with
"--network-plugin=<..>", the value was not passed to kubelet. Therefore,
the additional param "--extra-config=kubelet.network-plugin=<..>"
was required.

This commit ensures that the value is being passed to kubelet, so
the extra-config value is no longer needed.

Signed-off-by: Martynas Pumputis <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@balopat
Copy link
Contributor

balopat commented Dec 20, 2018

@minikube-bot OK to test

@balopat
Copy link
Contributor

balopat commented Dec 20, 2018

Nice, thank you for the contribution!

@RA489
Copy link

RA489 commented Jan 11, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tstromberg tstromberg merged commit e6b60fb into kubernetes:master Jan 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brb, RA489, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brb @minikube-bot @balopat @RA489 @k8s-ci-robot @tstromberg