Update Ingress-NGINX to 0.21 Release #3365
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: diazjf If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
@aledbf ^ |
|
@minikube-bot OK to test |
| @@ -19,7 +19,7 @@ data: | |||
| hsts: "false" | |||
| kind: ConfigMap | |||
| metadata: | |||
| name: nginx-load-balancer-conf | |||
| name: nginx-configuration | |||
There was a problem hiding this comment.
Why the name change? nginx-load-balancer-conf is pretty specific (maybe could be nginx-ingress-configuration) but nginx-configuration seems too generic.
There was a problem hiding this comment.
@balopat your suggestion makes sense. I'll see if I can get it changed in the Ingress-Nginx repo first.
@aledbf @ElvinEfendi we currently have nginx-configuration set as the configmap name in https://github.com/kubernetes/ingress-nginx/blob/master/deploy/mandatory.yaml
We should keep this consistent in both Ingress-Nginx and Minikube. I think nginx-load-balancer-conf or ingress-nginx-conf makes the most sense.
There was a problem hiding this comment.
@diazjf we have that name since the start. I think you should rollback this change. Makes no sense to break existing deployments.
There was a problem hiding this comment.
@balopat reverted the configmap back!
Updates the Ingress-Nginx Addon to version 0.21.
diazjf
force-pushed
the
update-ingress-21
branch
from
aa4acd7
to
225219f
Compare
|
The one failure is a flake: #3196 |
Updates Ingress-Nginx to use 0.21 release.