Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart containerd after stopping alternate runtimes #3343

Merged
merged 2 commits into from
Nov 16, 2018

Commits on Nov 15, 2018

  1. Restart containerd after stopping alternate runtimes

    After stopping any runtimes that aren't being used, if we're using
    containerd then we need to restart it. This is because it competes with
    cri-o to listen on port 10010, causing a necesary plugin to not be
    installed. After stopping cri-o, we need to restart containerd so that
    the plugin is installed.
    
    I also added some preflight checks when using alternative runtimes.
    kubeadm checks to make sure the Docker service is running, so I disabled
    that. It also checks if a few ports are available; these are ports that
    containerd uses, so I also added them to the ignore list.
    
    This should finish the work started in kubernetes#3211, which stopped alternative
    runtimes but didn't restart containerd. I was able to run "minikube
    start" with containerd locally with this change.
    Priya Wadhwa committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    bea4b6c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Rebased with master and addressed code comments

    Priya Wadhwa committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    8a5394e View commit details
    Browse the repository at this point in the history