Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #3044 - mounted timestamps incorrect with windows host #3285

Merged
merged 7 commits into from
Jan 24, 2019

Conversation

ngoozeff
Copy link
Contributor

Test cases & resolution for #3044.

Original Behavior:

go test ./test/integration --tags integration -binary c:\programdata\chocolatey\bin\minikube.exe --minikube-start-args "--vm-driver hyperv" -run TestFunctional/Mounting --minikube-mount-args "--ip 192.168.128.103" -v
=== RUN   TestFunctional
=== RUN   TestFunctional/Mounting
=== PAUSE TestFunctional/Mounting
=== CONT  TestFunctional/Mounting
--- FAIL: TestFunctional (7.82s)
    --- FAIL: TestFunctional/Mounting (25.03s)
        mount_test.go:131: Invalid access time
              File: /mount-9p/fromhost
              Size: 5           Blocks: 1          IO Block: 65536  regular file
            Device: 10008eh/1048718d    Inode: 7           Links: 1
            Access: (0666/-rw-rw-rw-)  Uid: (    0/    root)   Gid: (    0/    root)
            Access: 1970-01-01 00:00:00.000000000 +0000
            Modify: 1970-01-01 00:00:00.000000000 +0000
            Change: 1970-01-01 00:00:00.000000000 +0000
             Birth: -
FAIL
FAIL    k8s.io/minikube/test/integration        33.428s

With this fix:

go test ./test/integration --tags integration -binary ..\..\out\minikube-windows-amd64.exe --minikube-start-args "--vm-driver hyperv" -run TestFunctional/Mounting --minikube-mount-args "--ip 192.168.128.103" -v
=== RUN   TestFunctional
=== RUN   TestFunctional/Mounting
=== PAUSE TestFunctional/Mounting
=== CONT  TestFunctional/Mounting
--- PASS: TestFunctional (7.61s)
    --- PASS: TestFunctional/Mounting (26.89s)
PASS
ok      k8s.io/minikube/test/integration        35.102s

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 31, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 31, 2018
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@ngoozeff
Copy link
Contributor Author

ngoozeff commented Nov 9, 2018

@tstromberg I've managed to reproduce these failures on my linux box. I think it might be related to the msize default for the mount command being too large for the tests. I'm currently investigating.

Only check access time is set for windows OS.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2018
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

Do you mind addressing the merge conflict? I'd like to see about merging this if it's still viable. My apologies for the unnecessarily long delay in reviewing this PR.

@ngoozeff
Copy link
Contributor Author

Will do - I'll take a look over the weekend.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngoozeff
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tstromberg tstromberg merged commit 20c7325 into kubernetes:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants