Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images and improve parsing for kubernetes 1.11 #3255

Closed
wants to merge 3 commits into from
Closed

Add images and improve parsing for kubernetes 1.11 #3255

wants to merge 3 commits into from

Conversation

mlgibbons
Copy link
Contributor

Adds support for a distinct list of images cached for v1.11

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mlgibbons
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aaron-prindle

If they are not already assigned, you can assign the PR to them by writing /assign @aaron-prindle in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@mlgibbons
Copy link
Contributor Author

/assign @aaron-prindle

@tstromberg tstromberg changed the title K8s v1.11.0 image list update Add parsing for kubernetes 1.11 versions Oct 17, 2018
@tstromberg tstromberg changed the title Add parsing for kubernetes 1.11 versions Add images and improve parsing for kubernetes 1.11 Oct 17, 2018
tstromberg
tstromberg reviewed Oct 17, 2018
View reviewed changes
pkg/minikube/machine/cache_images.go
@@ -160,9 +160,6 @@ func replaceWinDriveLetterToVolumeName(s string) (string, error) {
return "", err
}
path := vname + s[3:]
if _, err := os.Stat(filepath.Dir(path)); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh! You're quite right. I'd created the branch based on the commit which incorporated my other PR. Apologies. I've sorted that out and raised another PR (I could not figure out how to sort it out in the previous branch/PR) which can be found here #3262. Cheers.

@mlgibbons mlgibbons force-pushed the k8s-v1.11.0-image-list-update branch from f2cddfc to eff050c Compare October 18, 2018 05:21
@tstromberg
Copy link
Contributor

Obsoleted by #3262

@tstromberg tstromberg closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg left review comments

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlgibbons @k8s-ci-robot @minikube-bot @tstromberg @aaron-prindle