Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "kubectl proxy" instead of a NodePort to expose the dashboard. #3210

Merged
merged 16 commits into from
Oct 4, 2018
Merged

Use "kubectl proxy" instead of a NodePort to expose the dashboard. #3210

merged 16 commits into from
Oct 4, 2018

Commits on Oct 3, 2018

  1. Use "kubectl proxy" instead of a NodePort to expose the dashboard. 

    This provides an additional level of security, by enforcing host checking, applying port randomization, and requiring explicit user intent to expose the service to the host.
    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    df54c6a View commit details
    Browse the repository at this point in the history

  2. Fix service port indentation.

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    21776a0 View commit details
    Browse the repository at this point in the history

  3. Improve readability of ISO download errors + include URL. 

    This is a separate issue I bumped into while developing the dashboard
PR.
    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    bc2dbe3 View commit details
    Browse the repository at this point in the history

  4. Switch the label back to k8s-app instead of app for minikube compatib… 

    …ility.
    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    ca9ca6f View commit details
    Browse the repository at this point in the history

  5. Block until the proxy URL is healthy. 

    This is necessary now that there is no proper service endpoint to block
on.
    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    8fd45bc View commit details
    Browse the repository at this point in the history

  6. Address lint issues resulting from the dashboard proxy refactor.

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    ac6dacf View commit details
    Browse the repository at this point in the history

  7. Double HTTP wait time and make error messages more readable.

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    4c35c50 View commit details
    Browse the repository at this point in the history

  8. Add function comments, improve proxy stdout log message

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    2956621 View commit details
    Browse the repository at this point in the history

  9. Fix overzealous replacement of namespace -> ns that broke URL generation

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    d38705a View commit details
    Browse the repository at this point in the history

  10. Update integration tests to handle newly persistant dashboard.

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    c079bb1 View commit details
    Browse the repository at this point in the history

  11. Add missing reference to cmd.

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    57054ac View commit details
    Browse the repository at this point in the history

  12. Removed unneccesary changes to download errors

    @tstromberg
    tstromberg committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    7feb46e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2018

  1. Use %v for errors instead of %s

    @tstromberg
    tstromberg committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    534325e View commit details
    Browse the repository at this point in the history

  2. Respect the -p flag to set the appropriate profile.

    @tstromberg
    tstromberg committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    fd0d466 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dashboard_on_demand

    @tstromberg
    tstromberg committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    dc6d1ba View commit details
    Browse the repository at this point in the history

  4. Let gofmt 1.10.4 rewrite service_test.go. 

    NOTE: This differs against what 1.11 would do, but matches our current
Travis CI configuration.
    @tstromberg
    tstromberg committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    687b62c View commit details
    Browse the repository at this point in the history