-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the default crio-bin configuration #3190
Conversation
Possibly the standard registry should be merged with the /etc/sysconfig/crio.minikube ? That already sets the |
Tried to use a well-defined storage provisioner, so that it can be used by crictl and podman too... But Jenkins didn't like it, for some reason. |
crio.conf(5) says: storage_driver="" CRIO storage driver (default is "overlay") Note: overlay and overlay2 are the same driver
@afbjorklund - Any idea what the OSX-Hyperkit errors are all about? They seem like a flake, but one I haven't seen yet:
|
@minikube-bot OK to test |
@tstromberg : have only tried libvirt (kvm2), sorry |
Also fixes issue #2835 (registries missing) |
@minikube-bot OK to test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-picked some of the podman changes, since they are really for crio-bin. (#2757)
use the standard directory and a bind-mount, instead of a prefixed storage directory
add the standard docker registry, so that you can run/pull images (like e.g. busybox)
We also need the crictl.yaml fixes, but that needs to be versioned on the CRI (#3043)