Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Kubernetes 1.12+ #3180

Merged
merged 4 commits into from
Oct 5, 2018

Conversation

outcoldman
Copy link
Contributor

@outcoldman outcoldman commented Sep 28, 2018

Fixes #3164

Support for k8s 1.12+, also keeping support for old versions of k8s.

See this comment for the list of incompatibilities with 1.12 #3164 (comment)

  1. It uses kubeadm.k8s.io/v1alpha1 for kubeadm. Kubernetes 1.12 does not support version v1alpha1. Only v1alpha2. The recommended version is v1alpha3. I used kubeadm config upgrade ... to convert v1alpha1 to v1alpha1 and to v1alpha3.

  2. This addon is not available /usr/bin/kubeadm alpha phase addon kube-dns, I guess it should use coredns instead (change in kubeadm to change kube-dns to coredns )

  3. The argument cadvisor-port is not available in k8s-1.12

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: outcoldman
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

If they are not already assigned, you can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 28, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dlorenc
Copy link
Contributor

dlorenc commented Sep 28, 2018

@minikube-bot OK to test

@outcoldman
Copy link
Contributor Author

@dlorenc is it related to my change? or just a test issue? I can change back ‘1.10’ as default, that probably should keep all the test green.

@outcoldman
Copy link
Contributor Author

@dlorenc I switched it back to 1.10.0 as default, that way the tests should work.

@outcoldman
Copy link
Contributor Author

tests are still failing, is it me or some configuration issues?

@tamalsaha
Copy link
Member

@outcoldman , please see #3132 (comment) comment. I am not sure if that is relevant.

@outcoldman
Copy link
Contributor Author

@tamalsaha hard to tell, considering that I am using by default the same version as before, not sure how that can affect tests

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

pkg/minikube/bootstrapper/kubeadm/kubeadm.go Show resolved Hide resolved
bootstrapTokens:
- groups:
- system:bootstrappers:kubeadm:default-node-token
token: 599s02.8i3w2yyyay8t0onm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this value arrived at?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have used kubeadm config upgrade, cleared all the default values, just by accident left this one. I will remove it.

pkg/minikube/bootstrapper/kubeadm/versions.go Show resolved Hide resolved
@tstromberg
Copy link
Contributor

FYI: The remaining flakes appear to be due to #3163 - now resolved. There are other flakes, of course.

@minikube-bot OK to test

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Oct 4, 2018

Please update Docker to v18.06.1 for supporting ProcMount: kubernetes/kubernetes#64283 docker-archive/docker-ce@67fe100

@outcoldman
Copy link
Contributor Author

@tstromberg update PR description and removed token generated by kubeadm config upgrade

@tstromberg tstromberg changed the title Support for Kubernetes 1.12+ Initial support for Kubernetes 1.12+ Oct 5, 2018
@tstromberg tstromberg merged commit 7365178 into kubernetes:master Oct 5, 2018
@outcoldman outcoldman deleted the k8s-1.12 branch October 5, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants