Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config parameter for the cri socket path #3154

Merged
merged 3 commits into from
Nov 15, 2018

Conversation

afbjorklund
Copy link
Collaborator

Closes #3153

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Sep 24, 2018

Looks like some failing tests in travis:

    	kubeadm_test.go:245: actual config does not match expected.  actual:

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Sep 24, 2018

Not sure if cri-socket should be a top-level citizen, but it was that way in kubeadm...
The current complementary configuration options are the other hand totally low-level ?

    --extra-config=kubelet.container-runtime=remote \
    --extra-config=kubelet.container-runtime-endpoint=/var/run/crio/crio.sock \
    --extra-config=kubelet.image-service-endpoint=/var/run/crio/crio.sock \

Will look at the test suites.

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Sep 24, 2018

It seems that it inserted a newline, so I suppose the template needs to be modified slightly...

FAIL k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm 0.154s

@afbjorklund
Copy link
Collaborator Author

ok k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm 0.141s

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2018
@afbjorklund
Copy link
Collaborator Author

Note that kubeadm chokes on unix:// since it is "not an absolute path"...

@RA489
Copy link

RA489 commented Oct 16, 2018

@afbjorklund this PR needs rebase.

Also fix the syntax for CRI-O, adding unix://
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants