minikube tunnel #3015

balopat · 2018-07-25T00:52:38Z

An implementation of minikube tunnel based on #2413.

k8s-ci-robot · 2018-07-25T00:52:43Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

minikube-bot · 2018-07-25T00:53:07Z

Can one of the admins verify this patch?

balopat · 2018-07-25T01:38:21Z

cla signed.

balopat · 2018-07-25T02:16:53Z

cc @dlorenc

cmd/minikube/cmd/tunnel.go

pkg/minikube/tunnel/route_windows.go

docs/contributors/mocking.md

mocks/github.com/docker/machine/libmachine_mocks/API.go

pkg/minikube/tunnel/loadbalancer_patcher.go

pkg/minikube/tunnel/reporter.go

balopat · 2018-07-30T15:57:10Z

Couple of things while I was working on the comments:
1.) I found a bug in the implementation: the daemon currently survives while I stop, delete and recreate a machine however doesn't pick up the new ip address. I either have to change the design to pick up the new ip address or to share fate with the machine (stop the daemon when minikube stops).
2.) as a newbie golanger I overdesigned the abstractions for testability and created unnecessarily large amount of interface code for DI. As I'm reading more about this, there seems to be a lot of opportunity to simplify by passing func types around instead.
A larger rework is coming soon.

balopat · 2018-08-21T17:04:13Z

A lot changed in the last month:

I reemoved the mocking framework and rolled my own stubs and fakes.
I introduced the tunnel registry in order to be able to cleanup for orphaned tunnels (see design doc updates too)
the tunnel process now shares fate with the minikube cluster - if the cluster stops, the tunnel exits

I still have some outstanding tasks:

refactor and validate windows version
refactor and validate linux version
setup script for the whitebox integration tests in the tunnel package
write integration test for tunnel
found a bug - number of /usr/local/bin/docker-machine-driver-hyperkit processes keep increasing
found another issue - with hyperkit created machines the network interface (bridge100) sometimes does not forward packets. ifconfig deletem en8 && ifconfig addm en8 seems to help - maybe just mention it in the docs?
update godocs
restructure commits

k8s-ci-robot · 2018-08-28T16:31:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: balopat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [balopat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tstromberg · 2018-10-17T22:07:24Z

pkg/minikube/tunnel/registry.go

+			return e
+		}
+	}
+	defer f.Close()


If the content of this JSON file has any importance, check the error from f.Close().

tstromberg · 2018-10-17T22:08:03Z

pkg/minikube/tunnel/registry.go

+	if err != nil {
+		return fmt.Errorf("error removing tunnel %s", err)
+	}
+	defer f.Close()


Check the error here too.

tstromberg · 2018-10-17T22:09:58Z

pkg/minikube/tunnel/registry_test.go

+		},
+		{
+			name: "Register + Remove + List",
+			test: func(t *testing.T, reg *persistentRegistry) {


Still this. table driven tests should never contain test-specific logic: http://go/gotestcomments#when-to-use-table-driven-tests

tstromberg · 2018-10-17T22:10:34Z

pkg/minikube/tunnel/registry_test.go

+		},
+		{
+			name: "Register + Remove + List",
+			test: func(t *testing.T, reg *persistentRegistry) {


Name your errors 'err' when possible.

tstromberg · 2018-10-17T22:17:54Z

pkg/minikube/tunnel/tunnel.go

+func (t *minikubeTunnel) updateTunnelStatus() *Status {
+	glog.V(3).Info("updating tunnel status...")
+	t.status.MinikubeState, _, t.status.MinikubeError = t.clusterInspector.getStateAndHost()
+	//TODO(balintp): clean this up to be more self contained


Clean this up, or remove the TODO. The grossness is self-evident.

tstromberg · 2018-10-17T22:19:42Z

pkg/minikube/tunnel/tunnel.go

+	machineAPI libmachine.API,
+	configLoader config.Loader,
+	v1Core v1.CoreV1Interface, registry *persistentRegistry, router router) (*minikubeTunnel, error) {
+	clusterInspector := &clusterInspector{


name this "ci" so we don't have to guess if you mean the struct name or the local variable.

tstromberg · 2018-10-17T22:20:43Z

pkg/minikube/tunnel/tunnel.go

+	return fmt.Errorf("there is already a running tunnel for this machine: %s", id)
+}
+
+func newTunnel(machineName string,


Keep function signatures as a single line when possible. When it isn't possible, there is your hint that you should take a config struct.

tstromberg · 2018-10-17T22:22:29Z

pkg/minikube/tunnel/tunnel.go

+
+}
+
+type minikubeTunnel struct {


It's difficult to tell the difference between the minikubeTunnel struct and tunnel struct. Can you adjust one of the names to be more distinct?

minikube.tunnel.minikubeTunnel is a rather perverse naming stutter, but since the struct name is private I won't worry too much about this.

tstromberg · 2018-10-17T22:28:30Z

pkg/minikube/tunnel/tunnel.go

+
+		exists, conflict, _, err := t.router.Inspect(t.status.TunnelID.Route)
+		if err != nil {
+			t.status.RouteError = fmt.Errorf("error checking for route state: %s", err)


Can this call return now? That would help to de-indent the non-error flow.

Same elsewhere in this function. https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow

tstromberg · 2018-10-17T22:29:03Z

pkg/minikube/tunnel/tunnel_manager.go

+
+func NewManager() *Manager {
+	return &Manager{
+		delay: 5 * time.Second,


Move this magic number to a const so that it's self-documenting.

tstromberg · 2018-10-17T22:31:20Z

Approved with minor nitpicks. Thanks!

paultiplady · 2018-10-18T18:12:54Z

Looking forward to giving this a spin, thanks for the hard work here!

omeid · 2018-12-01T02:36:17Z

This looks very interesting and I am keen to give it a crack, any chance this could be cut into a release?

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 25, 2018

balopat force-pushed the tunnel branch 2 times, most recently from c0314fd to ed3b4ba Compare July 25, 2018 01:31

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 25, 2018

aaron-prindle reviewed Jul 25, 2018

View reviewed changes

cmd/minikube/cmd/tunnel.go Show resolved Hide resolved

aaron-prindle reviewed Jul 25, 2018

View reviewed changes

pkg/minikube/tunnel/route_windows.go Outdated Show resolved Hide resolved

dlorenc reviewed Jul 26, 2018

View reviewed changes

balopat changed the title ~~Tunnel~~ [wip] tunnel Aug 20, 2018

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2018

balopat force-pushed the tunnel branch from ed3b4ba to b766603 Compare August 21, 2018 17:00

balopat and others added 10 commits August 27, 2018 08:02

machine config loading, fakeStore for tests, small fixes

8fb3edb

minikube tunnel

c04b84d

adding registry for tunnels

a7d124d

removed some unnecessary interfaces

dcf208e

registry is wired up to individual tunnel

9e73808

cleanup tunnels command is wired up to cleanup flag

34c5d88

work in progress...regisrty introduced

2114e4c

work in progress...regisrty introduced

228ed39

windows version works

94d19b1

glog instead of logrus + some wip conflict handling

9080b0e

balopat force-pushed the tunnel branch from ecfa5d9 to 9080b0e Compare August 28, 2018 16:31

balopat added 5 commits September 28, 2018 16:27

Merge branch 'master' into tunnel

3edb93f

ran golinter on pkg/minikube/tunnel

5cf91e0

Merge branch 'master' into tunnel

0e6f9dc

big cleanup

f2e0ee0

removed lc_all

157eeef

balopat mentioned this pull request Oct 1, 2018

LoadBalancer support #2834

Closed

balopat added 11 commits October 3, 2018 18:58

review comments

2dbcd93

review comments

7accb7d

Merge branch 'master' into tunnel

6116038

further review comments

cb45876

linting, LC_ALL=C for unix

9b94eb0

removing unrelated changes

a695115

removing unrelated changes

ace1146

fix signature in integration tests

295dce0

remove stuttering

76e5d9d

cleanup tunnels before running integration tests

a7b0c54

lint

8f05699

tstromberg approved these changes Oct 17, 2018

View reviewed changes

balopat added 3 commits October 18, 2018 09:15

code cleanup

bcd9a43

code cleanup

5fc3490

Merge branch 'master' into tunnel

1323e56

balopat removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2018

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2018

balopat merged commit ae9f4b2 into kubernetes:master Oct 18, 2018

balopat deleted the tunnel branch October 18, 2018 18:01

danehans mentioned this pull request Nov 28, 2018

Updates service dns doc to refer to issue 370 and gke clusters kubernetes-retired/kubefed#453

Merged

balopat mentioned this pull request Dec 13, 2018

[Feature Request] Enable host DNS resolution in virtualbox driver by default #3451

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minikube tunnel #3015

minikube tunnel #3015

balopat commented Jul 25, 2018 •

edited

Loading

k8s-ci-robot commented Jul 25, 2018

minikube-bot commented Jul 25, 2018

balopat commented Jul 25, 2018

balopat commented Jul 25, 2018

balopat commented Jul 30, 2018

balopat commented Aug 21, 2018 •

edited

Loading

k8s-ci-robot commented Aug 28, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg Oct 17, 2018

tstromberg commented Oct 17, 2018

paultiplady commented Oct 18, 2018

omeid commented Dec 1, 2018

minikube tunnel #3015

minikube tunnel #3015

Conversation

balopat commented Jul 25, 2018 • edited Loading

k8s-ci-robot commented Jul 25, 2018

minikube-bot commented Jul 25, 2018

balopat commented Jul 25, 2018

balopat commented Jul 25, 2018

balopat commented Jul 30, 2018

balopat commented Aug 21, 2018 • edited Loading

k8s-ci-robot commented Aug 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tstromberg commented Oct 17, 2018

paultiplady commented Oct 18, 2018

omeid commented Dec 1, 2018

balopat commented Jul 25, 2018 •

edited

Loading

balopat commented Aug 21, 2018 •

edited

Loading