Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gates support for Kubeadm #2951

Merged
merged 4 commits into from
Jul 16, 2018
Merged

Add feature gates support for Kubeadm #2951

merged 4 commits into from
Jul 16, 2018

Conversation

kairen
Copy link
Contributor

@kairen kairen commented Jun 30, 2018 •
edited
Loading

The commit reused the --feature-gates flag to parse Kubeadm and component feature gates. Therefore, we can use the --feature-gates flag to enable an alpha/experimental feature for Kubeadm, such as Auditing, SelfHosting, ..., etc.

Self hosting preview:

asciicast

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kairen
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

Assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@kairen kairen mentioned this pull request Jun 30, 2018
Closed
dlorenc
dlorenc reviewed Jul 3, 2018
View reviewed changes
pkg/minikube/config/types.go Outdated
ContainerRuntime string
NetworkPlugin string
FeatureGates string
KubeadmFeatureGates string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to reuse the existing FeatureGates field here instead of adding a new one?

Copy link
Contributor Author

@kairen kairen Jul 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will try to remove it and reuse FeatureGates field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlorenc I have been updated, could you review this changes? thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jul 9, 2018

@minikube-bot OK to test

@kairen
Copy link
Contributor Author

kairen commented Jul 11, 2018

Hi @dlorenc, Could this PR be merged? Some tests don't seem to be caused by this feature.

@dlorenc dlorenc merged commit ad576fa into kubernetes:master Jul 16, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jul 16, 2018

We're going to get a release out early this week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kairen @k8s-ci-robot @minikube-bot @dlorenc