Rm localkube #2911
Merged
Rm localkube #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaron-prindle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I think you might have to rebase, some of the tests here are still trying to run with bootstrapper=localkube |
aaron-prindle
force-pushed
the
rm-localkube
branch
from
7259952
to
3d4d7be
Compare
dlorenc
approved these changes
Jun 20, 2018
|
Let's hold off on merging this for a few days though, we might need to get a 0.28.1 point release out. |
|
@aaron-prindle want to rebase and get this in? |
aaron-prindle
force-pushed
the
rm-localkube
branch
from
d0e6b75
to
c06869c
Compare
|
done |
…to /var/lib/minikube
|
OK, I think this is ready to go. |
|
Gotta love PRs that remove 2M LoC 😉 |
emmanuelCarre
added a commit
to emmanuelCarre/website
that referenced
this pull request
Oct 1, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option had been removed. Reference this option in documentation is not needed any more.
emmanuelCarre
added a commit
to emmanuelCarre/website
that referenced
this pull request
Oct 1, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option had been removed. Reference this option in documentation is not needed any more.
emmanuelCarre
added a commit
to emmanuelCarre/website
that referenced
this pull request
Oct 1, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been removed. Reference this option in documentation is not needed any more.
emmanuelCarre
added a commit
to emmanuelCarre/website
that referenced
this pull request
Oct 7, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been removed. Reference this option in documentation is not needed any more.
emmanuelCarre
added a commit
to emmanuelCarre/website
that referenced
this pull request
Oct 7, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been removed. Reference this option in documentation is not needed any more.
emmanuelCarre
added a commit
to emmanuelCarre/website
that referenced
this pull request
Oct 7, 2018
Since PR kubernetes/minikube#2911, get-k8s-versions option has been removed. Reference this option in documentation is not needed any more.
This was referenced Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
branch based off of: #2870