Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend kernel config to support dummy network interface and openvswitch with vxlan #2876

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

brb
Copy link
Contributor

@brb brb commented Jun 6, 2018

The missing configuration prevents Weave Net from running on minikube (weaveworks/weave#3124).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: brb
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

Assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dlorenc
Copy link
Contributor

dlorenc commented Jun 6, 2018

@minikube-bot OK to test

@brb
Copy link
Contributor Author

brb commented Jun 7, 2018

Is there anything I can do about the CI failures?

@dlorenc dlorenc merged commit f8a52cb into kubernetes:master Jun 7, 2018
@pgandhipfpt
Copy link

I built minikube after getting these changes . and then starting weavenet , container is showing "CrashLoopBackOff"

I am trying on mac Sierra .
These are the steps I did
a. I got changes on my mac in minikube folder
b.cd /Users/$NAME/go/src/k8s.io/minikube/
make
c ./out/minikube start
d. kubectl get pods --all-namespaces
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system etcd-minikube 1/1 Running 0 1m
kube-system kube-addon-manager-minikube 1/1 Running 0 1m
kube-system kube-apiserver-minikube 1/1 Running 0 1m
kube-system kube-controller-manager-minikube 1/1 Running 0 1m
kube-system kube-dns-86f4d74b45-md2m6 3/3 Running 0 1m
kube-system kube-proxy-9h8t5 1/1 Running 0 1m
kube-system kube-scheduler-minikube 1/1 Running 0 1m
kube-system kubernetes-dashboard-5498ccf677-kgflm 1/1 Running 0 1m
kube-system storage-provisioner 1/1 Running 0 1m

e.kubectl apply -f "https://cloud.weave.works/k8s/net?k8s-version=$(kubectl version | base64 | tr -d '\n')"

f.kubectl get pods --all-namespaces
NAMESPACE NAME READY STATUS RESTARTS AGE
kube-system etcd-minikube 1/1 Running 0 21m
kube-system kube-addon-manager-minikube 1/1 Running 0 21m
kube-system kube-apiserver-minikube 1/1 Running 0 21m
kube-system kube-controller-manager-minikube 1/1 Running 0 21m
kube-system kube-dns-86f4d74b45-md2m6 3/3 Running 0 22m
kube-system kube-proxy-9h8t5 1/1 Running 0 22m
kube-system kube-scheduler-minikube 1/1 Running 0 21m
kube-system kubernetes-dashboard-5498ccf677-kgflm 1/1 Running 0 22m
kube-system storage-provisioner 1/1 Running 0 22m
kube-system weave-net-nm7f2 1/2 CrashLoopBackOff 8 16m

To verify that I have this fix, I tried this

grep CONFIG_DUMMY ./deploy/iso/minikube-iso/board/coreos/minikube/linux-4.9_defconfig
CONFIG_DUMMY=m
grep CONFIG_OPENVSWITCH ./deploy/iso/minikube-iso/board/coreos/minikube/linux-4.9_defconfig
CONFIG_OPENVSWITCH=m

I am very new to k8s . Please let me know If I missed anything

@brb
Copy link
Contributor Author

brb commented Jun 11, 2018

@pgandhipfpt Can you please open a new issue https://github.com/weaveworks/weave/issues/new? Please provide all requested information in the issue template and in addition, an output of zgrep OPENVSWITCH /proc/config.gz. Thanks.

@pgandhipfpt
Copy link

Thanks @brb . Opened weaveworks/weave#3318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants