Address issues with image caching

[mlgibbons]

See #2844

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mlgibbons
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: r2d4

Assign the PR to them by writing /assign @r2d4 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[mlgibbons]

CLA signed.

[dlorenc]

@minikube-bot OK to test

[mlgibbons]

Looking at the Jenkins failures none seem on a first look to be directly related related to the changes.
I'm unclear how to drill into or rerun the tests or the process for how to move fwd when tests fail.
If someone could advise or opine on the I can work on addressing any issues. Cheers.

• Linux-None
  On calling kube-init
  [preflight] Some fatal errors occurred:
  [ERROR DirAvailable--data-minikube]: /data/minikube is not empty

• Minishift-Linux-KVM
  Seems like a env setup error
  Setting Docker configuration on the remote daemon...
  Copying certs to the local machine directory...
  . FAIL E0526 00:11:28.682426 550 start.go:370] Error starting the VM: Error creating the VM. Error creating machine: Error running provisioning: Copying ca.pem to machine dir failed: open /home/jenkins/.minishift/ca.pem: permission denied. Retrying.
  Error starting the VM: Error creating the VM. Error creating machine: Error running provisioning: Copying ca.pem to machine dir failed: open /home/jenkins/.minishift/ca.pem: permission denied
  exit_with_message 1 'Error starting Minishift VM

• OSX-Hyperkit
  Fails in loading the addin image into the cluster
  Is this a transient error as the image had been cached successfully?

  E0525 16:15:53.571524 7361 start.go:234] Error updating cluster: loading cached images: loading cached images: loading image /Users/jenkins/.minikube/cache/images/k8s.gcr.io/kube-addon-manager_v8.6: loading docker image: /tmp/kube-addon-manager_v8.6: Process exited with status 1
  . Output: Aliases:
  map[string]string{}
  Override:
  map[string]interface {}{"v":"10"}
  PFlags:
  map[string]viper.FlagValue{"insecure-registry":viper.pflagValue{flag:(*pflag.Flag)(0xc420483680)}, "vm-driver":viper.pflagValue{flag:(*pflag.Flag)(0xc420482be0)}, "profile":viper.pflagValue{flag:(*pflag.Flag)(0xc420579e00)}, "apiserver-ips":viper.pflagValue{flag:(*pflag.Flag)(0xc420483540)}, "dns-domain":viper.pflagValue{flag:(*pflag.Flag)(0xc4204835e0)}, "disable-driver-mounts":viper.pflagValue{flag:(*pflag.Flag)(0xc420482aa0)}, "host-only-cidr":viper.pflagValue{flag:(*pflag.Flag)(0xc420482f00)}, "mount":viper.pflagValue{flag:(*pflag.Flag)(0xc420482960)}, "kvm-network":viper.pflagValue{flag:(*pflag.Flag)(0xc420483040)}, "container-runtime":viper.pflagValue{flag:(*pflag.Flag)(0xc420483900)}, "cpus":viper.pflagValue{flag:(*pflag.Flag)(0xc420482d20)}, "feature-gates":viper.pflagValue{flag:(*pflag.Flag)(0xc420483a40)}, "bootstrapper":viper.pflagValue{flag:(*pflag.Flag)(0xc420579ea0)}, "apiserver-name":viper.pflagValue{flag:(*pflag.Flag)(0xc420483400)}, "apiserver-names":viper.pflagValue{flag:(*pflag.Flag)(0xc4204834a0)}, "mount-string":viper.pflagValue{flag:(*pflag.Flag)(0xc420482a00)}, "network-plugin":viper.pflagValue{flag:(*pflag.Flag)(0xc4204839a0)}, "xhyve-disk-driver":viper.pflagValue{flag:(*pflag.Flag)(0xc4204830e0)}, "docker-opt":viper.pflagValue{flag:(*pflag.Flag)(0xc420483360)}, "extra-config":viper.pflagValue{flag:(*pflag.Flag)(0xc420483b80)}, "memory":viper.pflagValue{flag:(*pflag.Flag)(0xc420482c80)}, "disk-size":viper.pflagValue{flag:(*pflag.Flag)(0xc420482e60)}, "docker-env":viper.pflagValue{flag:(*pflag.Flag)(0xc4204832c0)}, "kubernetes-version":viper.pflagValue{flag:(*pflag.Flag)(0xc420483860)}, "nfs-shares-root":viper.pflagValue{flag:(*pflag.Flag)(0xc420483220)}, "registry-mirror":viper.pflagValue{flag:(*pflag.Flag)(0xc4204837c0)}, "cache-images":viper.pflagValue{flag:(*pflag.Flag)(0xc420483ae0)}, "keep-context":viper.pflagValue{flag:(*pflag.Flag)(0xc4204828c0)}, "nfs-share":viper.pflagValue{flag:(*pflag.Flag)(0xc420483180)}, "hyperv-virtual-switch":viper.pflagValue{flag:(*pflag.Flag)(0xc420482fa0)}, "iso-url":viper.pflagValue{flag:(*pflag.Flag)(0xc420482b40)}}
  Env:
  map[string]string{}
  Key/Value Store:
  map[string]interface {}{}
  Config:
  map[string]interface {}{"wantreporterrorprompt":false, "ingress":true}
  Defaults:
  map[string]interface {}{"alsologtostderr":"false", "log_dir":"", "reminderwaitperiodinhours":24, "wantreporterror":false, "wantreporterrorprompt":true, "wantkubectldownloadmsg":true, "wantnonedriverwarning":true, "wantupdatenotification":true, "showdriverdeprecationnotification":true, "showbootstrapperdeprecationnotification":true, "v":"0"}

[mlgibbons]

I'm going to close this pull request and open two seperate ones to keep the unreliable image caching changes separate from the incorrect image codes changes which in retrospect I should have done in the first place.