Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct case for Hyper-V module name. #2700

Closed
wants to merge 2 commits into from

Conversation

gbraad
Copy link
Contributor

@gbraad gbraad commented Apr 11, 2018

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbraad
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

Assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gbraad
Copy link
Contributor Author

gbraad commented Apr 11, 2018

/assign @dlorenc

@gbraad
Copy link
Contributor Author

gbraad commented Apr 11, 2018

@dlorenc, this is a fix that came after the 0.14.0 tagged release of docker/machine. Some of the information can be found here... docker/machine#4426, and in #2634

If you actually look carefully at https://github.com/kubernetes/minikube/commits/v0.25.2 you can see @r2d4 took the fix I suggested => d564056 with the correct case. If this gets merged, we can look at a better solution long-term for machine-drivers/machine as it would be preferred to use a case insensitive check

@gbraad
Copy link
Contributor Author

gbraad commented Apr 13, 2018

Fixed in main brnach

@gbraad gbraad closed this Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants