Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): minikube start --mount --mountsting without write permission #2671

Merged
merged 1 commit into from
Sep 4, 2018
Merged

fix(cli): minikube start --mount --mountsting without write permission #2671

merged 1 commit into from
Sep 4, 2018

Conversation

NsLib
Copy link
Contributor

@NsLib NsLib commented Apr 3, 2018

fix #2661

var mountTemplate = `
sudo mkdir -p {{.Path}} || true;
sudo mount -t 9p -o trans=tcp,port={{.Port}},dfltuid={{.UID}},dfltgid={{.GID}},version={{.Version}},msize={{.Msize}} {{.IP}} {{.Path}};
sudo chmod 775 {{.Path}}`

The last command (sudo chmod 775 {{.Path}}) can be failed silently when we mount /Users into the VM.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NsLib
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

Assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NsLib NsLib changed the title fix(cli): \minikube start --mount --mountsting\ without wirte permission fix(cli): \minikube start --mount --mountsting\ without write permission Apr 3, 2018
@NsLib NsLib changed the title fix(cli): \minikube start --mount --mountsting\ without write permission fix(cli): minikube start --mount --mountsting without write permission Apr 3, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@NsLib
Copy link
Contributor Author

NsLib commented Apr 3, 2018

/assign @luxas

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2018
@dlorenc
Copy link
Contributor

dlorenc commented Jul 17, 2018

@minikube-bot OK to test

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 16, 2018
@dlorenc dlorenc merged commit a7a5ede into kubernetes:master Sep 4, 2018
@haf
Copy link

haf commented Dec 9, 2018

root@eventstore-0:/var/lib/eventstore# ls -lah
total 257M
-rw-r--r-- 1 501 dialout    8 Dec  9 21:33 chaser.chk
-rw-r--r-- 1 501 dialout 257M Dec  9 21:33 chunk-000000.000000
-rw-r--r-- 1 501 dialout    8 Dec  9 21:31 epoch.chk
drwxr-xr-x 1 501 dialout   64 Dec  9 21:31 index
-rw-r--r-- 1 501 dialout    8 Dec  9 21:31 truncate.chk
-rw-r--r-- 1 501 dialout    8 Dec  9 21:33 writer.chk

or

root@influxdb-0:/var/lib/influxdb# ls -lah
total 1.5K
drwxr-xr-x 1 501 dialout 128 Dec  9 21:32 data
drwxr-xr-x 1 501 dialout  96 Dec  9 21:32 meta
drwx------ 1 501 dialout 128 Dec  9 21:32 wal

With minikube start --mount-string "$(pwd)/data:/data" --mount and corresponding hostPath volume declarations:

image

  • minikube version: v0.30.0
  • hyperkit
  • macOS 10.13.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube --mount is broken on OS X
7 participants