-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend hyper-v module name to fix cmdlet collision with vmware powercli #2577
Conversation
Fixes kubernetes#2226 Signed-off-by: Dave May <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: davemay99 Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
/assign @jimmidyson |
Looks good, but |
@jimmidyson I'm not familiar with the update procedure for Godeps.json. It doesn't appear that Comment is still relevant and/or updated. So if my fix was committed into docker/machine at docker/machine@15095c9, and I only changed files related to the hyperv driver, do I just need to update the Rev as follows?
|
We have some documentation here on the right way to update godeps: https://github.com/kubernetes/minikube/blob/master/docs/contributors/adding_a_dependency.md It's a bit of a pain, so if you want I can make the change for you. |
@dlorenc I would certainly appreciate it if you could handle the godeps issue on this update! I'd love to tackle updating godeps next time, but was hoping to get the underlying issue resolved quickly. |
Closing in favor of #2586 |
Fixes #2226
When VMware PowerCLI is installed alongside Hyper-V, there are multiple command collisions which prevent the hyperv Docker machine driver from working as expected. I fixed the underlying Docker Machine issue in docker/machine#4404 by prepending the hyper-v module name to ensure the correct module is used.
This pull request contains the latest hyperv machine driver code from the Docker Machine repo, which also includes code to help select the correct V-Switch if one is not specified.
Signed-off-by: Dave May [email protected]