-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add freshpod as a new addon #2423
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Copyright 2018 The Kubernetes Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: v1 | ||
kind: ReplicationController | ||
metadata: | ||
name: freshpod | ||
namespace: kube-system | ||
labels: | ||
k8s-app: freshpod | ||
kubernetes.io/minikube-addons: freshpod | ||
addonmanager.kubernetes.io/mode: Reconcile | ||
spec: | ||
replicas: 1 | ||
selector: | ||
k8s-app: freshpod | ||
addonmanager.kubernetes.io/mode: Reconcile | ||
template: | ||
metadata: | ||
labels: | ||
k8s-app: freshpod | ||
addonmanager.kubernetes.io/mode: Reconcile | ||
spec: | ||
containers: | ||
- name: freshpod | ||
image: gcr.io/google-samples/freshpod:v0.0.1 | ||
imagePullPolicy: IfNotPresent | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like other addons also use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I'm referencing other addons to add this option, so I'm also not sure why this option to need because the addon doc not mention. |
||
volumeMounts: | ||
- name: docker | ||
mountPath: /var/run/docker.sock | ||
volumes: | ||
- name: docker | ||
hostPath: | ||
type: Socket | ||
path: /var/run/docker.sock | ||
terminationGracePeriodSeconds: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
kubernetes.io/minikube-addons: freshpod
here as well, so that the Pods get this label, too?The documentation is unclear.