Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with localized groups #2237

Closed
wants to merge 1 commit into from
Closed

Fix issue with localized groups #2237

wants to merge 1 commit into from

Conversation

gbraad
Copy link
Contributor

@gbraad gbraad commented Nov 30, 2017

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2017
@codecov-io
Copy link

Codecov Report

Merging #2237 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2237   +/-   ##
=======================================
  Coverage   27.07%   27.07%           
=======================================
  Files          83       83           
  Lines        5699     5699           
=======================================
  Hits         1543     1543           
  Misses       3960     3960           
  Partials      196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856b1ad...1df0192. Read the comment docs.

@dlorenc
Copy link
Contributor

dlorenc commented Nov 30, 2017

Is there any way to do a full machine update through vendor/Godeps? Otherwise this will get overwritten on the next update.

@dlorenc
Copy link
Contributor

dlorenc commented Dec 11, 2017

Just FYI, I picked this up in #2299

@dlorenc
Copy link
Contributor

dlorenc commented Dec 11, 2017

Going to close this, I grabbed a full update from docker-machine.

@dlorenc dlorenc closed this Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbraad @codecov-io @dlorenc @k8s-ci-robot