Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notices for kvm and xhyve. #2227

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Nov 28, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2017
@codecov-io
Copy link

codecov-io commented Nov 28, 2017

Codecov Report

Merging #2227 into master will decrease coverage by 0.05%.
The diff coverage is 6.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   27.75%   27.69%   -0.06%     
==========================================
  Files          82       82              
  Lines        5541     5556      +15     
==========================================
+ Hits         1538     1539       +1     
- Misses       3807     3821      +14     
  Partials      196      196
Impacted Files Coverage Δ
pkg/minikube/config/config.go 28.12% <ø> (ø) ⬆️
pkg/minikube/cluster/cluster.go 30.09% <0%> (-1.43%) ⬇️
cmd/minikube/cmd/root.go 58.13% <100%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83cf99...aa795de. Read the comment docs.

@@ -206,9 +206,17 @@ func createHost(api libmachine.API, config MachineConfig) (*host.Host, error) {
driver = createVirtualboxHost(config)
case "vmwarefusion":
driver = createVMwareFusionHost(config)
case "kvm", "kvm2":
case "kvm":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to allow a user to suppress these messages so we don't break any automated scripts? I think that was an issue with some of the other warning messages we've added. We might be able to reuse one of our env vars or config values for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2017
if viper.GetBool(cfg.ShowDriverDeprecationNotification) {
fmt.Fprintln(os.Stderr, `WARNING: The kvm driver is now deprecated and support for it will be removed in a future release.
Please consider switching to the kvm2 driver, which is intended to replace the kvm driver.
See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm2-driver for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see a topic in the docs related to kvm2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. We'll get that in today too.

@dlorenc
Copy link
Contributor Author

dlorenc commented Nov 29, 2017

Ref #2231

@dlorenc dlorenc merged commit 9491ce6 into kubernetes:master Nov 29, 2017
@dlorenc dlorenc deleted the deprecarte branch November 29, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants